Adding tests that verify that the entire build setup is working as expected #1040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasoppermann
added
the
skip changeset
|
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Design Token Diff
|
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
rezrah
reviewed
Sep 2, 2024
| it('it should transform with css/variables format', () => { | ||
| const output = fs.readFileSync(`${basePath}/build/css/variables.css`, 'utf8') | ||
| const expectedOutput = `:root { | ||
| --prefix-base-color-blue-500: #2C29FF; /* The primary color for interactive elements. */ |
There was a problem hiding this comment.
qq... should this test instead assert that the prefix isn't applied to base tokens and only functional ones?
There was a problem hiding this comment.
Why? This is not the expected behavior for this config.
There was a problem hiding this comment.
Based on https://github.com/primer/primitives/pull/1040/files#r1740667105 I think I got my answer. The opinionated rules are applied in a different stage in the build process, so this isn't representative of an end-to-end test.
There was a problem hiding this comment.
Yes, I will add tests for this as well. Those are the baselines. :D
rezrah
reviewed
Sep 2, 2024
| const output = fs.readFileSync(`${basePath}/build/css/variables.css`, 'utf8') | ||
| const expectedOutput = `:root { | ||
| --prefix-base-color-blue-500: #2C29FF; /* The primary color for interactive elements. */ | ||
| --prefix-fg-color-link: #2C29FF; |
There was a problem hiding this comment.
Similar question for this one.. the input is fgColor but output is fg-color. Is that normals? I'd expect it to also be fgColor in output?
There was a problem hiding this comment.
This is currently just testing the default naming transforms. Here this is expected behavior. I will add our custom name transformers and then this would be the expected behavior.
There was a problem hiding this comment.
ah okay.. so there's another transformer that does that, i think that makes sense then 👍
rezrah
reviewed
Sep 2, 2024
rezrah
reviewed
Sep 2, 2024
rezrah
reviewed
Sep 2, 2024
lukasoppermann
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
List of notable changes:
What should reviewers focus on?
Steps to test: