-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix(docs): Add release notes for 0.296 #26726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds release notes documentation for Presto 0.296, aggregating missing and extracted release notes into a new Sphinx release page and wiring it into the docs release index. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Several release note entries contain obvious typos (e.g.,
senstive,senstivity,versio,enbled) and minor grammatical issues; it would be good to clean these up for a more polished 0.296 release page. - Some bullets appear duplicated or redundant (e.g., the compression codecs entry mentions ZSTD/ORC/Parquet twice, and the Postgres timestamp fix description is repeated); consider deduplicating or consolidating these for clarity.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several release note entries contain obvious typos (e.g., `senstive`, `senstivity`, `versio`, `enbled`) and minor grammatical issues; it would be good to clean these up for a more polished 0.296 release page.
- Some bullets appear duplicated or redundant (e.g., the compression codecs entry mentions ZSTD/ORC/Parquet twice, and the Postgres timestamp fix description is repeated); consider deduplicating or consolidating these for clarity.
## Individual Comments
### Comment 1
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:17` </location>
<code_context>
+* Improve ``MergeJoinForSortedInputOptimizer`` to do sort merge join when one side of the input is sorted. `#26361 <https://github.com/prestodb/presto/pull/26361>`_
+* Add :func:`array_transpose` to return a transpose of an array. `#26470 <https://github.com/prestodb/presto/pull/26470>`_
+* Add a configurable `clusterTag` config flag, which is returned from the `/v1/cluster` endpoints and displayed in the UI. `#26485 <https://github.com/prestodb/presto/pull/26485>`_
+* Add a new optimizer which do null skew mitigation for applicable semi joins. `#26251 <https://github.com/prestodb/presto/pull/26251>`_
+* Add a session property `query_types_enabled_for_history_based_optimization` to specifiy query types which will use HBO. `#26183 <https://github.com/prestodb/presto/pull/26183>`_
+* Add compression support for http2 protocol on cpp worker. `#26382 <https://github.com/prestodb/presto/pull/26382>`_
</code_context>
<issue_to_address>
**suggestion (typo):** Fix grammar in "which do null skew mitigation" phrase.
Change to either "which does null skew mitigation" or "which performs null skew mitigation" to fix the subject–verb agreement.
```suggestion
* Add a new optimizer which performs null skew mitigation for applicable semi joins. `#26251 <https://github.com/prestodb/presto/pull/26251>`_
```
</issue_to_address>
### Comment 2
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:18` </location>
<code_context>
+* Add :func:`array_transpose` to return a transpose of an array. `#26470 <https://github.com/prestodb/presto/pull/26470>`_
+* Add a configurable `clusterTag` config flag, which is returned from the `/v1/cluster` endpoints and displayed in the UI. `#26485 <https://github.com/prestodb/presto/pull/26485>`_
+* Add a new optimizer which do null skew mitigation for applicable semi joins. `#26251 <https://github.com/prestodb/presto/pull/26251>`_
+* Add a session property `query_types_enabled_for_history_based_optimization` to specifiy query types which will use HBO. `#26183 <https://github.com/prestodb/presto/pull/26183>`_
+* Add compression support for http2 protocol on cpp worker. `#26382 <https://github.com/prestodb/presto/pull/26382>`_
+* Add configuration property ``max-prefixes-count``. `#25550 <https://github.com/prestodb/presto/pull/25550>`_
</code_context>
<issue_to_address>
**issue (typo):** Correct the spelling of "specifiy".
Change "specifiy" to "specify" in this line.
```suggestion
* Add a session property `query_types_enabled_for_history_based_optimization` to specify query types which will use HBO. `#26183 <https://github.com/prestodb/presto/pull/26183>`_
```
</issue_to_address>
### Comment 3
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:42` </location>
<code_context>
+______________________________________
+* Fix Prestissimo Iceberg connector mixed case column name query error. `#26163 <https://github.com/prestodb/presto/pull/26163>`_
+* Add back session property native_max_partial_aggregation_memory for Presto C++. `#26389 <https://github.com/prestodb/presto/pull/26389>`_
+* Add support basic insertion to iceberg tables. `#26338 <https://github.com/prestodb/presto/pull/26338>`_
+* Add support for custom schemas in native sidecar function registry. `#26236 <https://github.com/prestodb/presto/pull/26236>`_
+* Support TPC-DS connector in Presto C++. `#24751 <https://github.com/prestodb/presto/pull/24751>`_
</code_context>
<issue_to_address>
**suggestion (typo):** Add missing preposition in "Add support basic insertion".
Consider changing this to: "Add support for basic insertion to Iceberg tables." for more natural phrasing and consistency with the other bullets.
```suggestion
* Add support for basic insertion to Iceberg tables. `#26338 <https://github.com/prestodb/presto/pull/26338>`_
```
</issue_to_address>
### Comment 4
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:50` </location>
<code_context>
+________________
+* Upgrade Netty to 4.1.128.Final to address `CVE-2025-59419 <https://github.com/advisories/GHSA-jq43-27x9-3v86>`_. `#26349 <https://github.com/prestodb/presto/pull/26349>`_
+* Upgrade RoaringBitmap to 1.3.0. `#26238 <https://github.com/prestodb/presto/pull/26238>`_
+* Upgrade at.favre.lib:bcrypt versio to 0.10.2 in response to `CVE-2020-15250<https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250>`_. `#26463 <https://github.com/prestodb/presto/pull/26463>`_
+* Upgrade calcite-core to 1.41.0 in response to `CVE-2025-48924 <https://github.com/advisories/GHSA-j288-q9x7-2f5v>`_. `#26248 <https://github.com/prestodb/presto/pull/26248>`_
+* Upgrade com.google.api:google-api-client version to 2.8.0 in response to the use of an outdated version. `#26063 <https://github.com/prestodb/presto/pull/26063>`_
</code_context>
<issue_to_address>
**issue (typo):** Fix "versio" typo and add missing space before the CVE link.
For the CVE reference, use valid reStructuredText link syntax so it renders properly, e.g.:
``... in response to `CVE-2020-15250 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250>`_``
```suggestion
* Upgrade at.favre.lib:bcrypt version to 0.10.2 in response to `CVE-2020-15250 <https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250>`_. `#26463 <https://github.com/prestodb/presto/pull/26463>`_
```
</issue_to_address>
### Comment 5
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:53` </location>
<code_context>
+* Upgrade io.dropwizard.metrics:metrics-core versio to 4.2.33 in response to the use of an outdated version. `#26199 <https://github.com/prestodb/presto/pull/26199>`_
</code_context>
<issue_to_address>
**issue (typo):** Correct "versio" to "version".
Suggested implementation:
```
* Upgrade at.favre.lib:bcrypt version to 0.10.2 in response to `CVE-2020-15250<https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250>`_. `#26463 <https://github.com/prestodb/presto/pull/26463>`_
```
```
* Upgrade io.dropwizard.metrics:metrics-core version to 4.2.33 in response to the use of an outdated version. `#26199 <https://github.com/prestodb/presto/pull/26199>`_
```
</issue_to_address>
### Comment 6
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:101-102` </location>
<code_context>
+* Replace default iceberg compression codec from GZIP to ZSTD. `#26399 <https://github.com/prestodb/presto/pull/26399>`_
+* Update iceberg time column catalog type from string to long. `#26523 <https://github.com/prestodb/presto/pull/26523>`_
+
+Mongodb Connector Changes
+_________________________
+* Add TLS/SSL support with automatic JKS and PEM certificate format detection. Configure using ``mongodb.tls.enabled``, ``mongodb.tls.keystore-path``, ``mongodb.tls.keystore-password``, ``mongodb.tls.truststore-path``, and ``mongodb.tls.truststore-password`` properties. `#25374 <https://github.com/prestodb/presto/pull/25374>`_
</code_context>
<issue_to_address>
**suggestion (typo):** Use the standard "MongoDB" capitalization.
Consider updating the heading text to "MongoDB Connector Changes" to match the product’s official styling.
```suggestion
MongoDB Connector Changes
_________________________
```
</issue_to_address>
### Comment 7
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:106` </location>
<code_context>
+* Add TLS/SSL support with automatic JKS and PEM certificate format detection. Configure using ``mongodb.tls.enabled``, ``mongodb.tls.keystore-path``, ``mongodb.tls.keystore-password``, ``mongodb.tls.truststore-path``, and ``mongodb.tls.truststore-password`` properties. `#25374 <https://github.com/prestodb/presto/pull/25374>`_
+* Upgrade MongoDB Java Driver to 3.12.14. `#25374 <https://github.com/prestodb/presto/pull/25374>`_
+
+Mysql Connector Changes
+_______________________
+* Fix timestamp handling when ``legacy_timestamp`` is disabled. Timestamp values are now correctly stored and retrieved as wall-clock times without timezone conversion. Previously, values were incorrectly converted using the JVM timezone, causing data corruption. `#26449 <https://github.com/prestodb/presto/pull/26449>`_
</code_context>
<issue_to_address>
**suggestion (typo):** Use the standard "MySQL" capitalization.
Update the heading text to "MySQL Connector Changes" to match the product name spelling.
```suggestion
MySQL Connector Changes
```
</issue_to_address>
### Comment 8
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:120` </location>
<code_context>
+* Add support for case-sensitive identifiers in Pinot. It can be enabled by setting ``case-sensitive-name-matching=true`` configuration in the catalog configuration. `#26239 <https://github.com/prestodb/presto/pull/26239>`_
+* Upgrade Pinot version to 1.3.0. `#25785 <https://github.com/prestodb/presto/pull/25785>`_
+
+Postgresql Connector Changes
+____________________________
+* Fix timestamp handling when ``legacy_timestamp`` is disabled. Timestamp values are now correctly stored and retrieved as wall-clock times without timezone conversion. Previously, values were incorrectly converted using the JVM timezone, causing data corruption. `#26449 <https://github.com/prestodb/presto/pull/26449>`_
</code_context>
<issue_to_address>
**suggestion (typo):** Use the standard "PostgreSQL" capitalization.
Consider renaming this heading to "PostgreSQL Connector Changes" to match the proper database name and maintain consistency.
Suggested implementation:
```
PostgreSQL Connector Changes
```
1. Ensure this section header actually exists in `release-0.296.rst` with the exact spelling "Postgresql Connector Changes". If the capitalization or spacing differs, adjust the `SEARCH` text accordingly.
2. Confirm that the underline below the heading (the line of `_` characters) is at least as long as the new heading text; Sphinx/RST requires the underline length to be ≥ the heading length. If necessary, extend the underline by one character to keep formatting correct.
</issue_to_address>
### Comment 9
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:128-129` </location>
<code_context>
+_______________________
+* Add support for case-sensitive identifiers in Redis. It can be enabled by setting ``case-sensitive-name-matching=true`` configuration in the catalog configuration. `#26078 <https://github.com/prestodb/presto/pull/26078>`_
+
+Singlestore Connector Changes
+_____________________________
+* Improved string type mapping, now supports varchar(len) where len <= 21844. `#25476 <https://github.com/prestodb/presto/pull/25476>`_
</code_context>
<issue_to_address>
**suggestion (typo):** Use the standard "SingleStore" capitalization.
To align with the vendor’s naming, rename this heading to “SingleStore Connector Changes”.
```suggestion
SingleStore Connector Changes
_____________________________
```
</issue_to_address>
### Comment 10
<location> `presto-docs/src/main/sphinx/release/release-0.296.rst:35-38` </location>
<code_context>
+* Replace the java standard base64 encoder with BaseEncoding from Guava. `#26557 <https://github.com/prestodb/presto/pull/26557>`_
+* Change encoding of refresh token secret key to AES. `#26487 <https://github.com/prestodb/presto/pull/26487>`_
+* Upgrade dagre-d3-es to 7.0.13 in response to `CVE-2025-57347 <https://github.com/advisories/GHSA-cc8p-78qf-8p7q>`_. `#26422 <https://github.com/prestodb/presto/pull/26422>`_
+* Upgrade the procedure architecture to support distributed executing procedures. `#26373 <https://github.com/prestodb/presto/pull/26373>`_
+
+Prestissimo (native Execution) Changes
</code_context>
<issue_to_address>
**suggestion (typo):** Rephrase "distributed executing procedures" for clarity.
Consider rewording to something like "support procedures executed in a distributed manner" or "support distributed execution of procedures" for clearer phrasing.
```suggestion
* Upgrade dagre-d3-es to 7.0.13 in response to `CVE-2025-57347 <https://github.com/advisories/GHSA-cc8p-78qf-8p7q>`_. `#26422 <https://github.com/prestodb/presto/pull/26422>`_
* Upgrade the procedure architecture to support distributed execution of procedures. `#26373 <https://github.com/prestodb/presto/pull/26373>`_
Prestissimo (native Execution) Changes
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Applying sourcery-ai suggestions Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
|
I am done with the first set of reviews, and the PR is now ready for the Release Shepherd - who for this release is @tdcmeehan. What I have done:
Work left to do: I believe that the work remaining in this PR for the Release Shepherd is:
|
Missing Release Notes
Amit Dutta
Jiaqi Zhang
Joe Abraham
Mariam AlMesfer
Pedro Pedreira
mapTypeKindToName()usage in PrestoCpp #26345 chore(native): RemovemapTypeKindToName()usage in PrestoCpp (Merged by: Amit Dutta)Tal Galili
XiaoDu
Xiaoxuan
tanjialiang
Extracted Release Notes
mongodb.tls.enabled,mongodb.tls.keystore-path,mongodb.tls.keystore-password,mongodb.tls.truststore-path, andmongodb.tls.truststore-passwordproperties.max-prefixes-count.case-sensitive-name-matching=trueconfiguration in the catalog configuration.enable-java-cluster-query-retryconfiguration inrouter-scheduler.propertiesto retry queries onrouter-java-urlwhen they fail onrouter-native-url.case-sensitive-name-matching=trueconfiguration in the catalog configuration.native_use_velox_geospatial_joinwhich will use the new optimized velox::SpatialJoinNode for geo-spatial joins, but flip to an basic velox::NestedLoopJoinNode for cross-checking if false. Enable thenative_use_velox_geospatial_joinflag as well.case-sensitive-name-matching=trueconfiguration in the catalog configuration.case-sensitive-name-matching=true.query_types_enabled_for_history_based_optimizationto specifiy query types which will use HBO.engine.hive.lock-enabledproperty when creating iceberg tables #26234 (Author: inf): feat(plugin-iceberg): Add support forengine.hive.lock-enabledproperty when creating iceberg tablesengine.hive.lock-enabledproperty when creating or altering iceberg tables.case-sensitive-name-matching=trueconfiguration in the catalog configuration.CVE-2025-48924 <https://github.com/advisories/GHSA-j288-q9x7-2f5v>_.CVE-2025-55163 <https://nvd.nist.gov/vuln/detail/CVE-2025-55163>_.SHOW STATSfor Timestamp with Timezone columns.String serializedCommitOutputargument withOptional<Object> commitOutputin thecom.facebook.presto.spi.eventlistener.QueryInputMetadataandcom.facebook.presto.spi.eventlistener.QueryOutputMetadataconstructors.getCommitOutputForRead()andgetCommitOutputForWrite()methods toConnectorCommitHandle, and deprecates the existinggetSerializedCommitOutputForRead()andgetSerializedCommitOutputForWrite()methods.ZSTDcompression codec in Parquet format.LZ4compression codec in ORC format.ZSTDcompression codec in Parquet format.LZ4compression codec in ORC format.CVE-2025-59419 <https://github.com/advisories/GHSA-jq43-27x9-3v86>_.MergeJoinForSortedInputOptimizerto do sort merge join when one side of the input is sorted.CVE-2022-36944<https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2022-36944>_.sorted_exchange_enabledsession property oroptimizer.experimental.sorted-exchange-enabledconfiguration property, the query planner will push sort operations into exchange nodes, eliminating redundant sorting steps and reducing memory usage for distributed queries with sort-merge joins. This feature is disabled by default.CVE-2025-57347 <https://github.com/advisories/GHSA-cc8p-78qf-8p7q>_.legacy_timestampis disabled. Timestamp values are now correctly stored and retrieved as wall-clock times without timezone conversion. Previously, values were incorrectly converted using the JVM timezone, causing data corruption.legacy_timestampis disabled. Timestamp values are now correctly stored and retrieved as wall-clock times without timezone conversion. Previously, values were incorrectly converted using the JVM timezone, causing data corruption.CVE-2020-15250<https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-15250>_.array_transposeto return a transpose of an array.clusterTagconfig flag, which is returned from the/v1/clusterendpoints and displayed in the UI.CVE-2025-59250 <https://github.com/advisories/GHSA-m494-w24q-6f7w>_.presto_cpp/properties-session:\`native_max_split_preload_per_driver```.All Commits
PlanConversionFailureInfotoNativeSidecarFailureInfo(refactor(native): ModifyPlanConversionFailureInfotoNativeSidecarFailureInfo#26720) (Pramod Satya)createRootand single root component for all UI pages (refactor: Use reactDOMcreateRootand single root component for all UI pages #26426) (Joe O'Hallaron)engine.hive.lock-enabledproperty when creating iceberg tables (feat(plugin-iceberg): Add support forengine.hive.lock-enabledproperty when creating iceberg tables #26234) (inf)tryMapNameToTypeKind()Velox API (chore(native): Remove usage of deprecatedtryMapNameToTypeKind()Velox API #26370) (Pedro Pedreira)mapTypeKindToName()usage in PrestoCpp (chore(native): RemovemapTypeKindToName()usage in PrestoCpp #26345) (Pedro Pedreira)Release Notes