-
Notifications
You must be signed in to change notification settings - Fork 5.5k
docs: Add release notes for 0.295 #26208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adds a new Sphinx release notes file for version 0.295 and populates it with both 'Missing Release Notes' (unchecked PR entries grouped by author) and fully formatted 'Extracted Release Notes' sections, integrating it into the main release documentation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Remove or complete the top-level “Missing Release Notes” checklist before merging so there are no unresolved placeholders in the published notes.
- Consolidate the repeated “Upgrade to Hadoop 3.4.1” sub-bullets under #24799 to eliminate duplicate entries.
- Consider sorting or grouping the release note entries (e.g., by PR number or feature category) to improve overall readability.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove or complete the top-level “Missing Release Notes” checklist before merging so there are no unresolved placeholders in the published notes.
- Consolidate the repeated “Upgrade to Hadoop 3.4.1” sub-bullets under #24799 to eliminate duplicate entries.
- Consider sorting or grouping the release note entries (e.g., by PR number or feature category) to improve overall readability.
## Individual Comments
### Comment 1
<location> `presto-docs/src/main/sphinx/release/release-0.295.rst:122` </location>
<code_context>
+* Improve `ApplyChangelogFunction` by moving it to connector-level functions following the pattern introduced in PR #25594. `#25871 <https://github.com/prestodb/presto/pull/25871>`_
+* Add Iceberg bucket scalar function. `#25951 <https://github.com/prestodb/presto/pull/25951>`_
+* Add ``iceberg.engine.hive.lock-enabled`` configuration to disable Hive locks. `#25615 <https://github.com/prestodb/presto/pull/25615>`_
+* Add supporting for specifying multiple transforms when adding a column. `#25862 <https://github.com/prestodb/presto/pull/25862>`_
+* Updated to implement ConnectorMetadata::finishDeleteWithOutput(). `#26134 <https://github.com/prestodb/presto/pull/26134>`_
+* Upgrade Iceberg version from 1.5.0 to 1.6.1. `#25768 <https://github.com/prestodb/presto/pull/25768>`_
</code_context>
<issue_to_address>
**issue (typo):** Change 'Add supporting for' to 'Add support for' for grammatical correctness.
Please update the wording to 'Add support for specifying multiple transforms when adding a column.'
```suggestion
* Add support for specifying multiple transforms when adding a column. `#25862 <https://github.com/prestodb/presto/pull/25862>`_
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Looks like we'll need to fix the release notes tool to generate the PR title using conventional commit format. |
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first pass, mostly fixing capitalization of products and correcting badly-formatted links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass review complete, mostly fixing capitalization of products and correcting badly-formatted links.
Will do at least one more review to revise some entries before I declare the draft ready to hand off to the release shepherd.
At that point I will summarize work done, and left to be done, as I usually do. See my comment on the 0.292 release notes PR, and my first comment and my second comment on the 0.294 release notes PR, for a preview of what to expect.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second review:
- tested and verified all links, including auto-gen to the PR for each entry, work - including the ones I fixed in my first review
- manually added Breaking Changes and populated the new topic with the one I know should be there
- fixed initial keywords for entries following the Order of changes in the Release Notes Guidelines
- moved some entries within sections following the Order of changes in the Release Notes Guidelines
- rechecked and fixed product names
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another review: add doc links, improve formatting and phrasing consistency.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor fixes
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another end-to-end review, add more doc links, move some entries from General Changes to Iceberg Connector Changes.
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final of my reviews for now, raising questions I'd like others to answer.
|
I am done with the first set of reviews, and the PR is now ready for the Release Shepherd. What I have done:
|
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!(docs)
All entries correctly ordered, formatted, phrased. Removals and moves from @tdcmeehan's review applied, then I pulled the updated branch again and generated a new doc build for an end-to-end review.
In my opinion, after commits are squashed this is ready to merge. Thanks everyone!
Co-authored-by: Timothy Meehan <[email protected]>
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!(docs)
Removals and moves from @tdcmeehan's second review applied, then I pulled the updated branch again and generated a new doc build for an end-to-end review.
In my opinion, after commits are squashed this is ready to merge. Thanks everyone!
Co-authored-by: Timothy Meehan <[email protected]>
steveburnett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Missing Release Notes
Amit Dutta
Arjun Gupta
Artem Selishchev
Ge Gao
Jialiang Tan
Nidhin Varghese
PRASHANT GOLASH
Richard Barnes
Timothy Meehan
Xiaoxuan Meng
haneel-kumar
juwentus1234
yangbin09
Extracted Release Notes
/functions/map./admin/session-property-managers.startTransactionIdandclearTransactionIdflag to client.assertStartTransactionandassertEndTransactionto support non-autocommit transaction testing scenarios better.GEOMETRY <https://prestodb.io/docs/current/language/types.html#geospatial>_ type in the Postgres connector.hive.orc_use_column_namesto toggle the accessing of columns based on the names recorded in the ORC file rather than their ordinal position in the file.SHOW CREATE VIEW.reactor.netty-http-client-enabledtotrue.getSqlInvokedFunctionsSPI andBuiltInPluginFunctionNamespaceManagerfor registering sql invoked functions #25597 (Author: Pratik Joseph Dabre): IntroducegetSqlInvokedFunctionsSPI andBuiltInPluginFunctionNamespaceManagerfor registering sql invoked functionsgetSqlInvokedFunctionsSPI in Presto, which only supports SQL invoked functions.BuiltInPluginFunctionNamespaceManager.AuthenticatorNotApplicableExceptionin presto-spi #25606 (Author: Jalpreet Singh Nanda (:imjalpreet)): AddAuthenticatorNotApplicableExceptionin presto-spiiceberg.engine.hive.lock-enabledconfiguration #25615 (Author: Hazmi): Fix iceberg commit atomicity & addiceberg.engine.hive.lock-enabledconfigurationiceberg.engine.hive.lock-enabledconfiguration to disable Hive locks.X-Presto-Retry-Queryheader to identify queries that are being retried on a backup cluster.http-server.http2.enabledtotrue.DELETEon columns with special characters in their names.CVE-2025-48924 <https://github.com/advisories/GHSA-j288-q9x7-2f5v>.case-sensitive-name-matching=true.system.jdbc.columnsto prevent errors.presto-sql-invoked-functions-plugin#25818 (Author: Pratik Joseph Dabre): Extract all inlined sql invoked functions into a new pluginpresto-sql-invoked-functions-pluginpresto-sql-invoked-functions-plugin. The following functions were moved: - replace_first - trail - key_sampling_percent - no_values_match - no_keys_match - any_values_match - any_keys_match - all_keys_match - map_remove_null_values - map_top_n_values - map_top_n_keys - map_top_n - map_key_exists - map_keys_by_top_n_values - map_normalize - array_top_n - remove_nulls - array_sort_desc - array_min_by - array_max_by - array_least_frequent - array_has_duplicates - array_duplicates - array_frequency - array_split_into_chunks - array_average - array_intersect.case-sensitive-name-matching=trueconfiguration in the catalog configuration.case-sensitive-name-matching=trueconfiguration in the catalog configuration.presto-native-sql-invoked-functions-pluginfor sidecar enabled clusters #25870 (Author: Pratik Joseph Dabre): [native] Introducepresto-native-sql-invoked-functions-pluginfor sidecar enabled clusterspresto-native-sql-invoked-functions-pluginthat contains all inlined SQL functions except those with overridden native implementations.apply_changelogfunction by migrating it from the global namespace to the connector-specific namespace. The function is now available asiceberg.system.apply_changelog()instead ofapply_changelog().ApplyChangelogFunctionby moving it to connector-level functions following the pattern introduced in PR Implement support for connector specific builtin functions #25594.native_index_lookup_join_max_prefetch_batcheswhich controls the max number of input batches to prefetch to do index lookup ahead. If it is zero, then process one input batch at a time.native_index_lookup_join_split_output. If this is true, then the index join operator might split output for each input batch based on the output batch size control. Otherwise, it tries to produce a single output for each input batch.native_unnest_split_output. If this is true, then the unnest operator might split output for each input batch based on the output batch size control. Otherwise, it produces a single output for each input batch.form-action 'self'and settingimg-src 'self'in response toCWE-693 <https://cwe.mitre.org/data/definitions/693.html>_. :pr:25910.current_timeandlocaltimeDateTimeFunctions to align with the session date/time #25985 (Author: Jalpreet Singh Nanda (:imjalpreet)): Updatecurrent_timeandlocaltimeDateTimeFunctions to align with the session date/timelocaltimeandcurrent_timein legacy timestamp semantics.presto-sql-helpersdirectory for inlined SQL invoked function plugins with plugin loading rules.SpecialFormExpressionandLambdaDefinitionExpressionin sidecar enabled clusters #26125 (Author: Pratik Joseph Dabre): Fix constant folding forSpecialFormExpressionandLambdaDefinitionExpressionin sidecar enabled clustersSpecialFormExpressionandLambdaDefinitionExpressionin sidecar enabled clusters.All Commits
AuthenticatorNotApplicableExceptionin presto-spi (Jalpreet Singh Nanda (:imjalpreet))localtimehandling for legacy timestamp semantics (Jalpreet Singh Nanda (:imjalpreet))current_timehandling for legacy timestamp semantics (Jalpreet Singh Nanda (:imjalpreet))connector_nametometadata.catalogstable (pratyakshsharma)iceberg.engine.hive.lock-enabledconfiguration (Hazmi)invalidate_metastore_cacheprocedure from iceberg (pratyakshsharma)TestHiveCommitHandleOutput(wangd)pushdown_subfields_for_map_subset(wangd)Release Notes