Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce resource utilization in TestHiveIntegrationSmokeTest #24817

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

ZacBlanco
Copy link
Contributor

@ZacBlanco ZacBlanco commented Mar 27, 2025

Description

  1. use tiny schema instead of SF1 except where necessary
  2. Increase JVM size to 5g

Goal is to reduce test flakiness and speed up runtime. This cut the average runtime by about 2-3 minutes on my M1 mac and decreased the maximum observed memory usage from ~3.7g to ~3.0g. The maximum usage depends on the tests which are running, but generally it is when two of the following are executing:

  • testGroupedExecution
  • testMaterializedPartitioning
  • testPartialMergePushdown
  • testWriteSortedTable
  • testWritePreferredOrderingTable

Related to #24775

Motivation and Context

Reduce test flakiness in CI and speed up build time

Impact

N/A

Test Plan

Existing tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

1. use tiny schema instead of SF1 except where necessary
2. Increase JVM size to 5g

Goal is to reduce test flakiness and speed up runtime. This cut
the average runtime by about 2-3 minutes on my M1 mac
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Mar 27, 2025
@ZacBlanco ZacBlanco marked this pull request as ready for review March 27, 2025 15:59
@ZacBlanco ZacBlanco requested a review from a team as a code owner March 27, 2025 15:59
@ZacBlanco ZacBlanco requested a review from jaystarshot March 27, 2025 15:59
@prestodb-ci prestodb-ci requested review from a team, ShahimSharafudeen and Dilli-Babu-Godari and removed request for a team March 27, 2025 15:59
@ZacBlanco ZacBlanco merged commit 94d6def into prestodb:master Mar 27, 2025
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants