Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use java matrix for arrow-flight tests #24810

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Use java matrix for arrow-flight tests #24810

merged 1 commit into from
Mar 27, 2025

Conversation

ZacBlanco
Copy link
Contributor

Description

Runs arrow flight tests on both 8 and 17.

Motivation and Context

More test coverage

Impact

N/A

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Mar 26, 2025
@ZacBlanco ZacBlanco marked this pull request as ready for review March 26, 2025 23:48
@ZacBlanco ZacBlanco requested review from czentgr and a team as code owners March 26, 2025 23:48
@ZacBlanco ZacBlanco requested a review from presto-oss March 26, 2025 23:48
@prestodb-ci prestodb-ci requested review from a team and ScrapCodes and removed request for a team March 26, 2025 23:48
@ZacBlanco ZacBlanco requested a review from BryanCutler March 26, 2025 23:48
ScrapCodes
ScrapCodes approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@ScrapCodes ScrapCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

BryanCutler
BryanCutler approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@BryanCutler BryanCutler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but if you can hold off on the changes from #24504 before merging?

czentgr
czentgr approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yingsu00 yingsu00 merged commit 54d192b into prestodb:master Mar 27, 2025
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScrapCodes ScrapCodes ScrapCodes approved these changes

@BryanCutler BryanCutler BryanCutler approved these changes

@yingsu00 yingsu00 yingsu00 approved these changes

@czentgr czentgr czentgr approved these changes

@presto-oss presto-oss Awaiting requested review from presto-oss presto-oss is a code owner automatically assigned from prestodb/committers

Assignees
No one assigned
Labels
from:IBM PR from IBM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZacBlanco @ScrapCodes @BryanCutler @yingsu00 @czentgr @prestodb-ci