Add new error code for queries killed due to too many tasks on cluster #24465
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sullivan-Patrick
requested review from
a team,
jaystarshot,
feilong-liu,
elharo and
ClarenceThreepwood
as code owners
swapsmagic
reviewed
Jan 30, 2025
presto-spi/src/main/java/com/facebook/presto/spi/StandardErrorCode.java
Outdated
Show resolved
Hide resolved
swapsmagic
previously approved these changes
Jan 30, 2025
shangm2
reviewed
Jan 30, 2025
presto-native-execution/velox
Outdated
There was a problem hiding this comment.
do we need to remove this or it is safe to keep it?
There was a problem hiding this comment.
Sorry I don't follow- what are you referring to removing?
There was a problem hiding this comment.
Well I don't understand what the changeset in GitHub is showing but it should be fixed :)
There was a problem hiding this comment.
No worries. That diff file is gone.
Sullivan-Patrick
force-pushed
the
task-count-error-code
branch
from
7b96da8 to
662ef83
Compare
Sullivan-Patrick
force-pushed
the
task-count-error-code
branch
from
662ef83 to
9f0ae68
Compare
elharo
approved these changes
Jan 31, 2025
shangm2
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In cases where a cluster needs to kill queries to stay under the configured threshold, we were using the same error code as cases where a query has more tasks than the configured threshold. This differentiates these and makes the former case an internal error.
Impact
In the first case, users will see updated error messaging reflecting the internal error.
Test Plan
Changes existing tests to reflect new error codes.
Contributor checklist