Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple query event listeners #24456

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanvdia
Copy link
Contributor

@evanvdia evanvdia commented Jan 29, 2025

Description

Add support for multiple query event listeners to allow multiple plugins to handle events independently.
Cherry-pick of trinodb/trino#3128

Motivation and Context

Issue : #24454

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

Add support for multiple query event listeners.

@evanvdia evanvdia requested review from steveburnett, elharo and a team as code owners January 29, 2025 16:34
@evanvdia evanvdia requested a review from presto-oss January 29, 2025 16:34
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Could an example be added?

@evanvdia evanvdia force-pushed the multiple_event_listener_changes branch from 676726f to 9e29e22 Compare January 29, 2025 17:44
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc!

Pull updated branch, new doc build, looks good. Thanks!

@tdcmeehan
Copy link
Contributor

Please attribute the author of the commit as mentioned in our contributing guide (see backport commits).

Please write a test with dummy event listeners. You should be able to create internal dummy listeners by writing properties to temp files, invoke the EventListenerManager with a dummy event and prove that two or more events are triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants