-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zookeeper version to fix common vulnerabilities and exposures(Do not merge) #24403
base: master
Are you sure you want to change the base?
Conversation
b819bf6
to
dc1cc7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests
{ | ||
return instance; | ||
} | ||
private TestingAccumuloServer() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has this been picked from Trino ? If so, can you follow the attribution guidelines and link to the commit you used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaneja The file we have taken it from trino, but it’s not a direct cherry-pick. We’ve made modifications to address the Accumulo test case failures
@@ -1936,7 +1936,7 @@ | |||
<dependency> | |||
<groupId>org.apache.zookeeper</groupId> | |||
<artifactId>zookeeper</artifactId> | |||
<version>3.4.14</version> | |||
<version>3.9.3</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JFYI - We do have an upgrade to Kafka dependencies as a WIP too -#24382
It should not impact this PR (tests seem to pass) cc : @ZacBlanco
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaneja The test case failures in this PR will be resolved once the Kafka upgrade PR is merged. The failures occur because the ZooKeeper client used in our Kafka connector doesn’t support newer versions of ZooKeeper. However, since newer versions of Kafka have fully removed support for ZooKeeper, these failures will disappear after the Kafka upgrade
cc : @ZacBlanco @imjalpreet
Thanks for the release note! Suggest adding a little description of the work done in the PR ("Upgrade zookeeper to 3.9.3") that results in fixing the security vulnerabilities.
|
Changes to fix test cases changes to fix testcase failure
c11877c
to
ab4f9e5
Compare
@steveburnett Corrected. Please check |
Description
Changes to upgrade zookeeper versions to 3.9.3 to remove vulnerabilities
Motivation and Context
The presto-accumulo, presto-delta,presto-hive,presto-kafka and presto-hudi have interdependencies with zookeeper version 3.4.14, which contain vulnerabilities. These vulnerabilities can be removed by upgrading the zookeeper dependency to 3.9.3
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.