Split maven modules with dependency on jetty http server #24395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
infvg and
bibith4
and removed request for
a team
ZacBlanco
force-pushed
the
jetty-split
branch
2 times, most recently
from
70f9f39 to
b252f85
Compare
This commit splits presto-main into presto-main and presto-main-base. presto-main-base is now the "main" module which builds the PrestoServer binary which includes the airlift http-server dependency. presto-main is all of the internal classes required to run presto and does not depend on jetty. This is in preparation to upgrade to Java 17 within Presto. The latest supported versions of Jetty require Java 17. This change allows us to maintain Presto-On-Spark compatibility with Java 8 as long as we keep the presto-main module compiling to java 8. Eventually these modules may be recombined after all PoS users have moved to Java 17 runtime.
ZacBlanco
force-pushed
the
jetty-split
branch
from
b252f85 to
8688d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit splits presto-main into presto-main and presto-main-base. presto-main continues to be the module responsible for the PrestoServer executable which includes the airlift http-server dependency. presto-main-base
is all of the internal classes required to run presto and does not depend on the airlift http-server dependency.
Motivation and Context
This is in preparation to upgrade to Java 17 within Presto. The entire Presto codebase is capable of moving to 17, however there are users of Presto-On-Spark which can't upgrade to 17 yet. This PR is a stopgap to allow us to upgrade a large portion of the codebase while supporting PoS on Java 8. PoS can now depend on
presto-main-baseinstead ofpresto-main.Eventually these modules may be recombined after all PoS users have moved to Java 17 runtime, or we can just upgrade their build compatibility to 17.
Impact
Should have no user-facing impact.
Test Plan
Existing tests.
Contributor checklist
Release Notes