[WIP] [native] Refactor PrestoToVeloxConnector for modularity #23920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhiseksaikia
force-pushed
the
update_header1
branch
3 times, most recently
from
acd4f3b to
4908d2d
Compare
|
@abhiseksaikia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
abhiseksaikia
force-pushed
the
update_header1
branch
2 times, most recently
from
27ae38f to
aa1d798
Compare
abhiseksaikia
force-pushed
the
update_header1
branch
from
aa1d798 to
a40c19a
Compare
|
@abhiseksaikia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
3 similar comments
|
@abhiseksaikia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@abhiseksaikia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@abhiseksaikia has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to the effort to split protocol headers, as seen in #23825. Specifically, this change focuses on splitting PrestoToVeloxConnector into connector-specific implementations.