Fix ARRAYS_OVERLAP function bug #23845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infvg
force-pushed
the
PRESTO_23730
branch
2 times, most recently
from
29f4c0c to
25c73bc
Compare
kewang1024
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Thanks @infvg for the fix, this makes sense to me, @rschlussel was looking at this issue before, let's have her review this PR as well
presto-main/src/test/java/com/facebook/presto/type/TestArrayOperators.java
Outdated
Show resolved
Hide resolved
infvg
force-pushed
the
PRESTO_23730
branch
2 times, most recently
from
4ef0f7a to
bad00d9
Compare
In some arrays containing arrays that contain null values, arrays_overlap was not properly comparing values. Switch to array_overlap to set based implementation. Resolves: prestodb#23730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In some arrays containing arrays that contain null values, arrays_overlap was not properly comparing values. Switch array_overlap to set based implementation.
Motivation and Context
Fixes #23730
Impact
None
Test Plan
Added the failing functions to unit tests and ran testArraysOverlap to confirm the functionality for the other queries remains the same.
== RELEASE NOTES ==