Fix client-tag selector rule in presto-router #23790
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the client-tags matches the request, the selector should choose the target group. The bug in the code doesn't do that. In th current code, when all the client-tags match incoming request, the selector is not matched.
Motivation and Context
When the client-tags matches the request, the selector should choose the target group. The bug in the code doesn't do that. In th current code, when all the client-tags match incoming request, the selector is not matched.
Impact
None
Test Plan
Verified manually by passing client-tags in the request and tried to match the client-tags configured in the selector. After the fix, it matches and the right target group is used
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: