Add build param to skip creating hardlinks #23782
Conversation
singcha
force-pushed
the
make-hard-links-configurable
branch
from
8e6e5b5 to
5e110d9
Compare
README.md
Outdated
| Presto uses the [Provisio](https://github.com/jvanzyl/provisio) plugin for packaging using hard links. If your filesystem doesn't support hard links, you can bypass hard links using: | ||
|
|
||
| ./mvnw clean install -presto.hard-link-includes='' | ||
|
|
There was a problem hiding this comment.
My sense is that the vast majority of filesystems folks use do support hardlinks. If that's the case, this is a very prominent callout in the README for relatively esoteric information. I would remove it, and perhaps add a comment in the POM instead.
There was a problem hiding this comment.
IMO - Anyone setting up project & building it, is going to look in README file for build instructions. Please let me know if you still think we should remove it and I can update the PR
There was a problem hiding this comment.
Maybe let's create a section toward the bottom for common issues with the build. For now, we can just put this there, but add other stuff as needed (incorrect JDK, Maven timeouts, etc).
singcha
force-pushed
the
make-hard-links-configurable
branch
from
5e110d9 to
49ac257
Compare
singcha
force-pushed
the
make-hard-links-configurable
branch
from
49ac257 to
2d3f639
Compare
Presto build fails when a filesystem with no support for hardlinks is used. Add new param to specify hardlink include jars.
singcha
force-pushed
the
make-hard-links-configurable
branch
from
2d3f639 to
eb93f15
Compare
|
@singcha for some reason this keeps failing the Maven checks. Can you look into why? |
Description
Presto build fails when a filesystem with no support for hardlinks is used. Add new param to specify hardlink include jars.
Motivation and Context
Fixes build issue when underlying filesystem doesn't support hardlinks
Test Plan
Built on devserver
== NO RELEASE NOTE ==