Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free unused buffer in chunk supplier during reset #23724

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenyangfb
Copy link
Contributor

Description

Currently chunk supplier keep buffers in bufferPool and usedBuffers, it never free those buffer, even with reset().

This PR free unused buffer in chunk supplier during reset

Impact

Test Plan

Tested with Spark workload

After the change
Reset unused buffers, used 17 chunks (8387584 bytes), unused 65 chunks (68157440 bytes)
Reset unused buffers, used 82 chunks (76545024 bytes), unused 4 chunks (4194304 bytes)

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... :pr:`12345`
* ... :pr:`12345`

Hive Connector Changes
* ... :pr:`12345`
* ... :pr:`12345`

If release note is NOT required, use:

== NO RELEASE NOTE ==

@chenyangfb chenyangfb force-pushed the orc_reset_chunk_supplier branch from 01405f7 to 3f8ec38 Compare September 27, 2024 23:23
@chenyangfb chenyangfb force-pushed the orc_reset_chunk_supplier branch from 3f8ec38 to 7cab405 Compare November 3, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant