[native] Add row expression optimizer #22927

pramodsatya · 2024-06-05T15:59:54Z

Description

Introduces capability to optimize and constant fold row expressions in the Presto native sidecar.
Adds class RowExpressionConverter to convert a velox exec::Expr to a Presto protocol::RowExpression.
Adds class RowExpressionOptimizer to optimize and constant fold a Presto RowExpression in the native sidecar (using RowExpressionConverter).

Motivation and Context

Please refer to #24126 for full context of the changes, this is as described in RFC-0006.

Test Plan

Unit tests for simple expression conversions are added in RowExpressionConverter.cpp.
Unit tests for simple expression optimizations are added in RowExpressionOptimizerTest.cpp.
Exhaustive end-to-end tests will be added in TestNativeExpressionOptimizer.java (please refer to the PR #24238).

Release Notes

== NO RELEASE NOTE ==

aditi-pandit

@pramodsatya : Have done a first round of comments. Will read your tests more closely once you address the comments here.

presto-native-execution/presto_cpp/main/PrestoServer.cpp

presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.h

presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp

presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.h

presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.h

presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp

presto-native-execution/presto_cpp/main/expression/tests/RowExpressionEvaluatorTest.cpp

pramodsatya

Thanks for the feedback @aditi-pandit, addressed the comments. Could you please take another look?

presto-native-execution/presto_cpp/main/expression/RowExpressionEvaluator.cpp

presto-native-execution/presto_cpp/main/expression/tests/RowExpressionEvaluatorTest.cpp

Summary: prestodb/presto#23331 adds a native expression optimizer to delegate expression evaluation to the native sidecar. This is used to constant fold expressions on the presto native sidecar, instead of on the presto java coordinator (which is the current behavior). prestodb/presto#22927 implements a proxygen endpoint to accept `RowExpression`s from `NativeSidecarExpressionInterpreter`, optimize them if possible (rewrite special form expressions), and compile the `RowExpression` to a velox expression with constant folding enabled. This velox expression is then converted back to a `RowExpression` and returned by the sidecar to the coordinator. When the constant folded velox expression is of type `velox::exec::ConstantExpr`, we need to return a `RowExpression` of type `ConstantExpression`. This requires us to serialize the constant value from `velox::exec::ConstantExpr` into `protocol::ConstantExpression::valueBlock`. This can be done by serializing the constant value vector to presto SerializedPage::column format, followed by base 64 encoding the result (reverse engineering the logic from `Base64Util.cpp::readBlock`). This PR adds a new function, `serializeSingleColumn`, to `PrestoVectorSerde`. This can be used to serialize input data from vectors containing a single element into a single PrestoPage column format (without the PrestoPage header). This function is not added to `PrestoBatchVectorSerializer` alongside the existing `serialize` function since that would require adding it as a virtual function in `BatchVectorSerializer` as well, and this is not desirable since the `PrestoPage` format is not relevant in this base class. There is an existing function `deserializeSingleColumn` in `PrestoVectorSerde` which is used to deserialize data from a single column, since `serializeSingleColumn` performs the inverse operation to this function, it is added alongside it in `PrestoVectorSerde`. Pull Request resolved: #10657 Reviewed By: amitkdutta Differential Revision: D66044754 Pulled By: pedroerp fbshipit-source-id: e509605067920f8207e5a3fa67552badc2ce0eba

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.h

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp

pramodsatya

Thanks for the feedback @aditi-pandit, addressed the review comments. Could you please take another look?

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp

aditi-pandit

Thanks @pramodsatya. Have reviewed the RowExpressionConverter class so far.

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp

presto-native-execution/presto_cpp/main/expression/CMakeLists.txt

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp

pramodsatya

Thanks for the suggestions @aditi-pandit. Refactored RowExpressionConverter and RowExpressionOptimizer into separate files in presto_cpp/main/types, and addressed the remaining comments. Could you please take another look?

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.h

presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp

presto-native-execution/presto_cpp/main/PrestoServer.cpp

presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp

aditi-pandit · 2025-01-07T22:30:01Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

+// case that can be simplified since 'a' is a variable here, so the WHEN clauses
+// that are required by Presto as switch expression arguments are returned in
+// the field 'arguments'.
+struct SwitchFormArguments {


This needn't be defined in the header here. It seems to have local usage only in the cpp file. Please move it there.

SwitchFormArguments is needed in the header because the member functions getSimpleSwitchFormArgs and getSwitchSpecialFormArgs return values of this type. Is it fine to retain it here?

Sorry missed that. You can move this struct within the RowExpressionConverter class.

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

presto-native-execution/presto_cpp/main/types/RowExpressionOptimizer.cpp

presto-native-execution/presto_cpp/main/types/tests/RowExpressionOptimizerTest.cpp

…bator#10657) Summary: prestodb/presto#23331 adds a native expression optimizer to delegate expression evaluation to the native sidecar. This is used to constant fold expressions on the presto native sidecar, instead of on the presto java coordinator (which is the current behavior). prestodb/presto#22927 implements a proxygen endpoint to accept `RowExpression`s from `NativeSidecarExpressionInterpreter`, optimize them if possible (rewrite special form expressions), and compile the `RowExpression` to a velox expression with constant folding enabled. This velox expression is then converted back to a `RowExpression` and returned by the sidecar to the coordinator. When the constant folded velox expression is of type `velox::exec::ConstantExpr`, we need to return a `RowExpression` of type `ConstantExpression`. This requires us to serialize the constant value from `velox::exec::ConstantExpr` into `protocol::ConstantExpression::valueBlock`. This can be done by serializing the constant value vector to presto SerializedPage::column format, followed by base 64 encoding the result (reverse engineering the logic from `Base64Util.cpp::readBlock`). This PR adds a new function, `serializeSingleColumn`, to `PrestoVectorSerde`. This can be used to serialize input data from vectors containing a single element into a single PrestoPage column format (without the PrestoPage header). This function is not added to `PrestoBatchVectorSerializer` alongside the existing `serialize` function since that would require adding it as a virtual function in `BatchVectorSerializer` as well, and this is not desirable since the `PrestoPage` format is not relevant in this base class. There is an existing function `deserializeSingleColumn` in `PrestoVectorSerde` which is used to deserialize data from a single column, since `serializeSingleColumn` performs the inverse operation to this function, it is added alongside it in `PrestoVectorSerde`. Pull Request resolved: facebookincubator#10657 Reviewed By: amitkdutta Differential Revision: D66044754 Pulled By: pedroerp fbshipit-source-id: e509605067920f8207e5a3fa67552badc2ce0eba

pramodsatya

Thanks @aditi-pandit, addressed the comments, could you please take another look?

presto-native-execution/presto_cpp/main/PrestoServer.cpp

presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.cpp

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

pramodsatya · 2025-01-12T20:47:01Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

+// case that can be simplified since 'a' is a variable here, so the WHEN clauses
+// that are required by Presto as switch expression arguments are returned in
+// the field 'arguments'.
+struct SwitchFormArguments {


SwitchFormArguments is needed in the header because the member functions getSimpleSwitchFormArgs and getSwitchSpecialFormArgs return values of this type. Is it fine to retain it here?

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

presto-native-execution/presto_cpp/main/types/RowExpressionOptimizer.cpp

presto-native-execution/presto_cpp/main/types/tests/RowExpressionOptimizerTest.cpp

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

aditi-pandit · 2025-01-23T19:50:39Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

+// case that can be simplified since 'a' is a variable here, so the WHEN clauses
+// that are required by Presto as switch expression arguments are returned in
+// the field 'arguments'.
+struct SwitchFormArguments {


Sorry missed that. You can move this struct within the RowExpressionConverter class.

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

aditi-pandit · 2025-02-05T05:34:12Z

presto-native-execution/presto_cpp/main/types/CMakeLists.txt

@@ -34,6 +34,15 @@ add_library(presto_velox_conversion OBJECT VeloxPlanConversion.cpp)

 target_link_libraries(presto_velox_conversion velox_type)

+add_library(presto_expression_converter RowExpressionConverter.cpp)


Both files can be compiled in a single library.

Yes, we don't need two objects here. Logically these two belong together.

aditi-pandit · 2025-02-05T05:36:53Z

presto-native-execution/presto_cpp/main/types/PrestoToVeloxExpr.h

@@ -22,6 +22,61 @@

 namespace facebook::presto {

+static const std::unordered_map<std::string, std::string> prestoOperatorMap() {
+  static const std::string prestoDefaultNamespacePrefix =


Move the function body to PrestoToVeloxExpr.cpp

aditi-pandit · 2025-02-05T05:39:42Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

+ public:
+  explicit RowExpressionConverter(memory::MemoryPool* pool) : pool_(pool) {}
+
+  /// Converts a velox constant expression of type exec::ConstantExpr to a


You can omit the types in the comments..."Converts a velox constant expression constantExpr to a Presto protocol constant expression". The types are readable from the function signatures.

aditi-pandit · 2025-02-05T06:10:25Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+      result["arguments"] = switchResult.arguments;
+    }
+  } else {
+    auto exprInputs = expr->inputs();


What kind of expressions could fall in the else part of this condition ?

Presto special form expressions that aren't of form SWITCH, such as COALESCE, IN, AND, OR etc,. are handled by this else part. Added a comment to indicate the same.

czentgr

Thanks. My initial review to get started. I haven't looked into all of the details.

czentgr · 2025-02-05T23:25:26Z

presto-native-execution/presto_cpp/main/types/RowExpressionOptimizer.h

+        veloxExprConverter_(pool, &typeParser_),
+        rowExpressionConverter_(RowExpressionConverter(pool)) {}
+
+  /// Optimizes all expressions from the input json array. If the expression


Nit (grammar): we don't need to use "would", "will" etc. We can outright state it.

If the expression optimization fails for any of the input expressions, the second value in
the returned pair is set to false and the returned json contains the exception.

Similar for the next sentence.

czentgr · 2025-02-05T23:28:05Z

presto-native-execution/presto_cpp/main/PrestoServer.cpp

+  if (result.second) {
+    VELOX_USER_CHECK(
+        result.first.is_array(),
+        "Output json should be an array of row expressions");


nit: "Output json should be an array of row expressions"
so it is not an arrow of row expressions? Why not state the fact?
"The output json is not an array of expressions".

czentgr · 2025-02-05T23:30:22Z

presto-native-execution/presto_cpp/main/types/CMakeLists.txt

@@ -34,6 +34,15 @@ add_library(presto_velox_conversion OBJECT VeloxPlanConversion.cpp)

 target_link_libraries(presto_velox_conversion velox_type)

+add_library(presto_expression_converter RowExpressionConverter.cpp)


Yes, we don't need two objects here. Logically these two belong together.

czentgr · 2025-02-05T23:43:44Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+
+protocol::TypeSignature getTypeSignature(const TypePtr& type) {
+  std::string typeSignature;
+  if (type->parameters().empty()) {


The idea is to separate the complex types from the scalar types, right?
If so, then you can use type->isPrimitiveType().
Then you don't check on the parameters and need a special case for DECIMAL (and any other primitive parameterized future type) - any special case would require changes here.

czentgr · 2025-02-05T23:52:56Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+      VELOX_USER_FAIL("Invalid type {}", type->toString());
+    }
+
+    typeSignature = complexTypeString + "(";


There is this logic to do all this rebuilding of the signature.
The velox type implementation provides the toString function.
The main issue is that it uses <> instead of () to handle the child types of the complex types, for example, MAP<INTEGER, INTEGER> instead of map(integer, integer) which is what this function produces if I am not mistaken.

So why don't we use the toString function on all types and then do the lower case and replacement of <> with () for the complex types. Would this be easier than all this code to build a type signature? Or am I missing something?

Thanks for the suggestion, Velox complex type's implementation of toString introduces these additional characters (<, >) and whitespaces that are not required in the Presto protocol TypeSignature. Instead of finding and replacing these characters, it would be simpler to construct the TypeSignature as per Presto's requirement in this helper function. In case the velox type's toString implementation changes in the future, this function would not need any changes.
Is it fine if this function is retained for now? As a follow-up, I could refactor the velox type's toString function to take in a custom delimiter as an argument, for this use-case it would be the pair (, ) and the default delimiters could be <, >?

czentgr · 2025-02-05T23:56:33Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+  if (input->_type == kSpecial) {
+    auto inputSpecialForm =
+        dynamic_cast<protocol::SpecialFormExpression*>(input.get());
+    VELOX_USER_CHECK(inputSpecialForm);


Are you using the VELOX_USER_CHECK to check for not null? Would be better to use VELOX_NOT_NULL instead.
We don't expect this to be user input that could be bad but we still need to protect if something went wrong. I guess this is debatable.

Replaced VELOX_USER_CHECK with VELOX_CHECK for cases where the input doesn't come from the user.

czentgr · 2025-02-06T00:01:46Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+    const std::vector<RowExpressionPtr>& arguments) {
+  SwitchFormArguments result;
+  // The switch case's 'expression' in simple form of the conditional cannot be
+  // inferred from Velox since it could evaluate all 'when' clauses to true or


Nit: since -> because.

I don't think I understand the comment.
From what I understand it means the velox switchExpr doesn't contain all the info to rebuild the switch row expression, right? So some info is taken from the input.

That's right, for a simple form switch expression such as case 1 when 1 then 32 + 1 when 1 then 34 end, the Velox switch expression inputs contain the following equal expressions: eq(1, 1), eq(1, 1). It is not possible to get the expression value in simple form of CASE conditional if all these equal expressions in velox evaluate to either true or false during constant folding. Hence, this expression is obtained from the input Presto switch expression. I have updated the comments with examples for different cases here, please let me know if any further changes are needed.

czentgr · 2025-02-06T00:10:14Z

presto-native-execution/presto_cpp/main/types/tests/RowExpressionConverterTest.cpp

+// Velox expression to Presto RowExpression conversion for different types of
+// expressions can be found in TestDelegatingExpressionOptimizer.java in
+// presto-native-sidecar-plugin.
+class RowExpressionConverterTest


Am I missing something or this converter test doesn't test switch expressions?

Unit tests were not added for special form expressions that require the input Presto protocol RowExpression for conversion (such as SWITCH) in the interest of avoiding large test json files. Added tests for SWITCH, IN special form expressions and BETWEEN call expression to RowExpressionOptimizerTest.cpp. Adding these tests to RowExpressionConverterTest.cpp would result in the test code duplicating much of the RowExpressionOptimizer logic with code repetition, so I feel it would be better to have these tests in RowExpressionOptimizerTest.cpp. Would that be fine?
End-to-end tests for various other expression types will be added in the subsequent Presto PR.

czentgr · 2025-02-06T00:17:15Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

+  /// simplified, and the switch expression arguments required by Presto are
+  /// returned in 'arguments'.
+  struct SwitchFormArguments {
+    bool isSimplified = false;


I don't see this ever being set to true in the new code. When processing the getSimpleSwitchFormArgs function it is never set but maybe it should be because otherwise why have this?

This is being set to true in the following check in getSimpleSwitchFormArgs:

... // If this is the first switch case that evaluates to true, return the // expression corresponding to this case. if (constVector->valueAt(0) && result.arguments.size() == 1) { return { true, veloxToPrestoRowExpression(caseValue, inputWhenArgs[1]), json::array()}; } ...

pramodsatya

Thanks for the feedback @aditi-pandit, @czentgr. I have addressed the review comments, could you please take another look?

pramodsatya · 2025-02-06T02:26:15Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+      VELOX_USER_FAIL("Invalid type {}", type->toString());
+    }
+
+    typeSignature = complexTypeString + "(";


Thanks for the suggestion, Velox complex type's implementation of toString introduces these additional characters (<, >) and whitespaces that are not required in the Presto protocol TypeSignature. Instead of finding and replacing these characters, it would be simpler to construct the TypeSignature as per Presto's requirement in this helper function. In case the velox type's toString implementation changes in the future, this function would not need any changes.
Is it fine if this function is retained for now? As a follow-up, I could refactor the velox type's toString function to take in a custom delimiter as an argument, for this use-case it would be the pair (, ) and the default delimiters could be <, >?

pramodsatya · 2025-02-06T02:32:58Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+  if (input->_type == kSpecial) {
+    auto inputSpecialForm =
+        dynamic_cast<protocol::SpecialFormExpression*>(input.get());
+    VELOX_USER_CHECK(inputSpecialForm);


Replaced VELOX_USER_CHECK with VELOX_CHECK for cases where the input doesn't come from the user.

pramodsatya · 2025-02-06T02:38:06Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+    const std::vector<RowExpressionPtr>& arguments) {
+  SwitchFormArguments result;
+  // The switch case's 'expression' in simple form of the conditional cannot be
+  // inferred from Velox since it could evaluate all 'when' clauses to true or


That's right, for a simple form switch expression such as case 1 when 1 then 32 + 1 when 1 then 34 end, the Velox switch expression inputs contain the following equal expressions: eq(1, 1), eq(1, 1). It is not possible to get the expression value in simple form of CASE conditional if all these equal expressions in velox evaluate to either true or false during constant folding. Hence, this expression is obtained from the input Presto switch expression. I have updated the comments with examples for different cases here, please let me know if any further changes are needed.

pramodsatya · 2025-02-06T18:01:49Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.h

+  /// simplified, and the switch expression arguments required by Presto are
+  /// returned in 'arguments'.
+  struct SwitchFormArguments {
+    bool isSimplified = false;


This is being set to true in the following check in getSimpleSwitchFormArgs:

... // If this is the first switch case that evaluates to true, return the // expression corresponding to this case. if (constVector->valueAt(0) && result.arguments.size() == 1) { return { true, veloxToPrestoRowExpression(caseValue, inputWhenArgs[1]), json::array()}; } ...

pramodsatya · 2025-02-06T21:24:55Z

presto-native-execution/presto_cpp/main/types/RowExpressionConverter.cpp

+      result["arguments"] = switchResult.arguments;
+    }
+  } else {
+    auto exprInputs = expr->inputs();


Presto special form expressions that aren't of form SWITCH, such as COALESCE, IN, AND, OR etc,. are handled by this else part. Added a comment to indicate the same.

pramodsatya · 2025-02-06T21:44:02Z

presto-native-execution/presto_cpp/main/types/tests/RowExpressionConverterTest.cpp

+// Velox expression to Presto RowExpression conversion for different types of
+// expressions can be found in TestDelegatingExpressionOptimizer.java in
+// presto-native-sidecar-plugin.
+class RowExpressionConverterTest


Unit tests were not added for special form expressions that require the input Presto protocol RowExpression for conversion (such as SWITCH) in the interest of avoiding large test json files. Added tests for SWITCH, IN special form expressions and BETWEEN call expression to RowExpressionOptimizerTest.cpp. Adding these tests to RowExpressionConverterTest.cpp would result in the test code duplicating much of the RowExpressionOptimizer logic with code repetition, so I feel it would be better to have these tests in RowExpressionOptimizerTest.cpp. Would that be fine?
End-to-end tests for various other expression types will be added in the subsequent Presto PR.

pramodsatya force-pushed the expr_endpt branch from e8f3c68 to 418b219 Compare July 25, 2024 21:49

pramodsatya changed the title ~~[WIP] Add proxygen endpoint for expression evaluation~~ [native] Add proxygen endpoint for expression evaluation Aug 5, 2024

pramodsatya mentioned this pull request Aug 5, 2024

Add function serializeSingleColumn to PrestoVectorSerde facebookincubator/velox#10657

Closed

pramodsatya force-pushed the expr_endpt branch from 418b219 to 50d6456 Compare August 5, 2024 08:32

pramodsatya requested review from aditi-pandit, tdcmeehan and czentgr August 5, 2024 08:33

tdcmeehan self-assigned this Aug 5, 2024

pramodsatya force-pushed the expr_endpt branch 2 times, most recently from 822f79f to 2352cd4 Compare September 11, 2024 14:52

aditi-pandit reviewed Sep 12, 2024

View reviewed changes

pramodsatya force-pushed the expr_endpt branch from 2352cd4 to 496bbc5 Compare September 17, 2024 02:41

pramodsatya commented Sep 17, 2024

View reviewed changes

pramodsatya force-pushed the expr_endpt branch from 496bbc5 to d9c3dcd Compare September 17, 2024 03:09

pramodsatya force-pushed the expr_endpt branch from d9c3dcd to e19ae51 Compare October 7, 2024 15:05

pramodsatya force-pushed the expr_endpt branch from e19ae51 to 747ef08 Compare November 4, 2024 13:40

pramodsatya force-pushed the expr_endpt branch from 747ef08 to 10bfc08 Compare December 2, 2024 02:40

pramodsatya requested a review from aditi-pandit December 2, 2024 02:40

aditi-pandit reviewed Dec 2, 2024

View reviewed changes

pramodsatya changed the title ~~[native] Add proxygen endpoint for expression evaluation~~ [native] Add row expression optimizer Dec 10, 2024

pramodsatya force-pushed the expr_endpt branch from 10bfc08 to 37ef905 Compare December 10, 2024 08:05

pramodsatya commented Dec 10, 2024

View reviewed changes

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp Outdated Show resolved Hide resolved

presto-native-execution/presto_cpp/main/expression/RowExpressionOptimizer.cpp Outdated Show resolved Hide resolved

pramodsatya force-pushed the expr_endpt branch from 37ef905 to 7425558 Compare December 10, 2024 17:17

pramodsatya marked this pull request as ready for review December 10, 2024 17:49

pramodsatya requested a review from a team as a code owner December 10, 2024 17:49

prestodb-ci added the from:IBM PR from IBM label Dec 10, 2024

prestodb-ci requested review from a team and imjalpreet and removed request for a team December 10, 2024 17:49

pramodsatya force-pushed the expr_endpt branch 2 times, most recently from 416d768 to b244385 Compare December 11, 2024 17:28

pramodsatya requested a review from aditi-pandit December 17, 2024 07:38

aditi-pandit reviewed Jan 3, 2025

View reviewed changes

pramodsatya force-pushed the expr_endpt branch 2 times, most recently from 6297ece to 7cbdc9c Compare January 6, 2025 23:31

pramodsatya commented Jan 7, 2025

View reviewed changes

pramodsatya force-pushed the expr_endpt branch from 7cbdc9c to ad0a9e2 Compare January 8, 2025 00:11

aditi-pandit reviewed Jan 8, 2025

View reviewed changes

pramodsatya force-pushed the expr_endpt branch from ad0a9e2 to c8eebef Compare January 14, 2025 06:13

pramodsatya commented Jan 14, 2025

View reviewed changes

pramodsatya force-pushed the expr_endpt branch 2 times, most recently from 28ebf78 to 0198811 Compare January 20, 2025 20:59

pramodsatya requested a review from aditi-pandit January 20, 2025 21:02

pramodsatya force-pushed the expr_endpt branch from 0198811 to 0a7405b Compare January 22, 2025 02:44

aditi-pandit reviewed Jan 30, 2025

View reviewed changes

pramodsatya force-pushed the expr_endpt branch 3 times, most recently from 0b96443 to 60eb032 Compare January 30, 2025 21:42

pramodsatya requested a review from aditi-pandit January 30, 2025 21:53

pramodsatya force-pushed the expr_endpt branch 3 times, most recently from 0da5052 to 6ef10b9 Compare February 4, 2025 17:42

aditi-pandit reviewed Feb 5, 2025

View reviewed changes

czentgr reviewed Feb 6, 2025

View reviewed changes

pramodsatya force-pushed the expr_endpt branch from 6ef10b9 to 791ed5b Compare February 6, 2025 23:06

pramodsatya commented Feb 6, 2025

View reviewed changes

[native] Add row expression optimizer

66b5c37

pramodsatya force-pushed the expr_endpt branch from 791ed5b to 66b5c37 Compare February 7, 2025 02:40

		@@ -34,6 +34,15 @@ add_library(presto_velox_conversion OBJECT VeloxPlanConversion.cpp)

		target_link_libraries(presto_velox_conversion velox_type)

		add_library(presto_expression_converter RowExpressionConverter.cpp)

[native] Add row expression optimizer #22927

Are you sure you want to change the base?

[native] Add row expression optimizer #22927

Conversation

pramodsatya commented Jun 5, 2024 • edited Loading

Description

Motivation and Context

Test Plan

Release Notes

aditi-pandit left a comment

Choose a reason for hiding this comment

pramodsatya left a comment

Choose a reason for hiding this comment

pramodsatya left a comment

Choose a reason for hiding this comment

aditi-pandit left a comment

Choose a reason for hiding this comment

pramodsatya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pramodsatya left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

czentgr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pramodsatya Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pramodsatya Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pramodsatya left a comment

Choose a reason for hiding this comment

pramodsatya Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pramodsatya Feb 6, 2025 • edited Loading

Choose a reason for hiding this comment

pramodsatya commented Jun 5, 2024 •

edited

Loading

pramodsatya Feb 6, 2025 •

edited

Loading

pramodsatya Feb 6, 2025 •

edited

Loading

pramodsatya Feb 6, 2025 •

edited

Loading

pramodsatya Feb 6, 2025 •

edited

Loading