Skip to content

Commit

Permalink
[native]Switch to use subfiled filters in dwio common
Browse files Browse the repository at this point in the history
  • Loading branch information
xiaoxmeng authored and amitkdutta committed Jan 29, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
1 parent 510024d commit e223cc1
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -19,14 +19,14 @@

#include <velox/type/fbhive/HiveTypeParser.h>
#include "velox/connectors/hive/HiveConnector.h"
#include "velox/connectors/hive/HiveConnectorUtil.h"
#include "velox/connectors/hive/HiveConnectorSplit.h"
#include "velox/connectors/hive/HiveDataSink.h"
#include "velox/connectors/hive/TableHandle.h"
#include "velox/connectors/hive/iceberg/IcebergDeleteFile.h"
#include "velox/connectors/hive/iceberg/IcebergSplit.h"
#include "velox/connectors/tpch/TpchConnector.h"
#include "velox/connectors/tpch/TpchConnectorSplit.h"
#include "velox/type/Filter.h"

namespace facebook::presto {

@@ -805,7 +805,7 @@ std::unique_ptr<connector::ConnectorTableHandle> toHiveTableHandle(
const protocol::Map<protocol::String, protocol::String>& tableParameters,
const VeloxExprConverter& exprConverter,
const TypeParser& typeParser) {
connector::hive::SubfieldFilters subfieldFilters;
common::SubfieldFilters subfieldFilters;
auto domains = domainPredicate.domains;
for (const auto& domain : *domains) {
auto filter = domain.second;
2 changes: 1 addition & 1 deletion presto-native-execution/velox
Submodule velox updated 45 files
+1 −1 .github/workflows/conbench_upload.yml
+2 −2 CMake/VeloxUtils.cmake
+4 −0 CMake/resolve_dependency_modules/simdjson.cmake
+2 −0 CMakeLists.txt
+6 −0 README.md
+1 −1 scripts/setup-centos9.sh
+2 −1 scripts/setup-helper-functions.sh
+1 −1 scripts/setup-macos.sh
+1 −1 scripts/setup-ubuntu.sh
+1 −1 setup.py
+4 −4 velox/common/caching/tests/AsyncDataCacheTest.cpp
+24 −0 velox/common/config/GlobalConfig.h
+2 −2 velox/common/file/tests/FaultyFileSystem.h
+1 −1 velox/common/future/VeloxPromise.h
+122 −0 velox/connectors/Connector.h
+2 −2 velox/connectors/hive/HiveConfig.h
+3 −3 velox/connectors/hive/HiveConnectorUtil.cpp
+5 −3 velox/connectors/hive/HiveConnectorUtil.h
+1 −4 velox/connectors/hive/HiveDataSource.h
+2 −2 velox/connectors/hive/TableHandle.cpp
+3 −6 velox/connectors/hive/TableHandle.h
+0 −3 velox/connectors/hive/iceberg/PositionalDeleteFileReader.h
+2 −2 velox/connectors/hive/tests/HiveConnectorUtilTest.cpp
+1 −3 velox/core/PlanNode.h
+2 −2 velox/dwio/common/tests/LoggedExceptionTest.cpp
+0 −2 velox/dwio/common/tests/utils/FilterGenerator.h
+6 −1 velox/exec/fuzzer/CacheFuzzer.cpp
+8 −7 velox/exec/tests/TableScanTest.cpp
+1 −1 velox/exec/tests/utils/HiveConnectorTestBase.h
+1 −1 velox/exec/tests/utils/PlanBuilder.cpp
+10 −27 velox/expression/Expr.cpp
+0 −13 velox/expression/Expr.h
+1 −1 velox/expression/tests/ExprEncodingsTest.cpp
+5 −6 velox/expression/tests/ExprTest.cpp
+26 −0 velox/flag_definitions/flags.cpp
+7 −2 velox/functions/lib/Re2Functions.cpp
+14 −0 velox/functions/lib/tests/Re2FunctionsTest.cpp
+1 −0 velox/functions/prestosql/registration/ArrayFunctionsRegistration.cpp
+40 −0 velox/functions/prestosql/tests/ArrayHasDuplicatesTest.cpp
+2 −0 velox/functions/prestosql/tests/BinaryFunctionsTest.cpp
+1 −0 velox/py/CMakeLists.txt
+5 −5 velox/substrait/SubstraitToVeloxPlan.cpp
+1 −1 velox/substrait/SubstraitToVeloxPlan.h
+3 −0 velox/type/Filter.h
+0 −3 velox/type/tests/SubfieldFiltersBuilder.h

0 comments on commit e223cc1

Please sign in to comment.