Skip to content

Commit

Permalink
Standardize on Guava for VisibleForTesting annotation
Browse files Browse the repository at this point in the history
  • Loading branch information
elharo committed Sep 12, 2024
1 parent 7727df8 commit 7b68207
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,11 @@
import com.facebook.presto.spi.resourceGroups.ResourceGroupQueryLimits;
import com.facebook.presto.sql.planner.Plan;
import com.facebook.presto.version.EmbedVersion;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.collect.Ordering;
import com.google.common.util.concurrent.ListenableFuture;
import io.airlift.units.DataSize;
import io.airlift.units.Duration;
import org.jheaps.annotations.VisibleForTesting;
import org.weakref.jmx.Flatten;
import org.weakref.jmx.Managed;
import org.weakref.jmx.Nested;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@
import com.facebook.presto.operator.TaskStats;
import com.facebook.presto.spi.PrestoException;
import com.facebook.presto.spi.QueryId;
import com.google.common.annotations.VisibleForTesting;
import com.google.common.base.Ticker;
import com.google.common.collect.ListMultimap;
import io.airlift.units.DataSize;
import io.airlift.units.Duration;
import org.jheaps.annotations.VisibleForTesting;

import javax.annotation.PostConstruct;
import javax.annotation.PreDestroy;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
import com.facebook.presto.spark.execution.shuffle.PrestoSparkShuffleInfoTranslator;
import com.facebook.presto.spark.execution.task.ForNativeExecutionTask;
import com.facebook.presto.spark.execution.task.NativeExecutionTaskFactory;
import com.google.common.annotations.VisibleForTesting;
import com.google.inject.Binder;
import com.google.inject.Module;
import com.google.inject.Scopes;
import com.google.inject.TypeLiteral;
import io.airlift.units.Duration;
import org.jheaps.annotations.VisibleForTesting;

import java.util.Optional;

Expand Down
1 change: 1 addition & 0 deletions src/checkstyle/presto-checks.xml
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@

<module name="IllegalImport">
<property name="illegalPkgs" value="org.weakref.jmx.internal" />
<property name="illegalPkgs" value="org.jheaps.annotations" />
<property name="illegalPkgs" value="jersey.repackaged" />
<property name="illegalPkgs" value="jdk.nashorn.internal" />
<property name="illegalPkgs" value="jdk.internal" />
Expand Down

0 comments on commit 7b68207

Please sign in to comment.