-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying whether you want sdists or not #81
Conversation
Sorry, I've not quite got the hang of reading Rust PRs yet, but please make sure there's an option for "prefer not to use them",and IMO that should be the default option), if that in fact is not already the case here (perhaps that is what is meant implictly by "you want to use sdists"). |
This PR adds the following options:
Do you think that suffices? |
Options seem great, but the default comes with a lot of nuance and introduces backwards compatability issues if you need to change much later down the road. I would personally suggest There's bewen a discussion in Pip world about changing the default and the problem with backwards compatability for them: pypa/pip#9140 (sorry long discussion) |
Hi @notatallshaw thanks for your input! I don't mind preferring wheels if you (as the expert :)) says it's a better idea! |
Like here 😢 : https://pypi.org/simple/pysdl2/ |
@tdejager I added thorough docs to the |
@pradyunsg what do you think of these options? What do you think should be the default here? |
Oh wow, 🙁, well Normal is definetly universally safe for rip. But the common example of user pain is when there's a new release and wheels are not released along side sdists immediatly. |
They're reasonable, although given that you have low backwards compatibility costs; I suggest using more granular control (eg: enabling people to say "get me X, Y&Z from an sdist with everything else being wheels".
Matching pip's default semantic of "use a wheel if available for a version, otherwise sdist for that version" is likely going to be the most compatible with existing user workflows. |
This adds the option to specify whether you want to use sdists, prefer them or only use sdists.