Final Bundle of VS Changes #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <DebugType>full</DebugType> | ||
| <Optimize>false</Optimize> | ||
| <OutputPath>bin\Debug\</OutputPath> | ||
| <DefineConstants>DEBUG;TRACE</DefineConstants> | ||
| <ErrorReport>prompt</ErrorReport> | ||
| <WarningLevel>4</WarningLevel> | ||
| <AndroidLinkMode>None</AndroidLinkMode> | ||
| <AndroidSupportedAbis>armeabi;armeabi-v7a;x86</AndroidSupportedAbis> | ||
| <AndroidSupportedAbis>armeabi,armeabi-v7a,x86</AndroidSupportedAbis> |
There was a problem hiding this comment.
Given the casing difference on line 28 and the use of commas rather than semicolons on line 36, will this still build on OSX?
There was a problem hiding this comment.
Yeah,
I tested in XS on my iMac. All these changes were just automatically done by Visual Studio so I left them as is.
Interestingly (and fortunately in my opinion), Xamarin Studio doesn't revert them back to the old format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prof. Gerber,
Here are a few final changes to get sensus fully integrated into the Microsoft's VS IDE.
The big thing was I had the wrong build configuration so I was building all the projects. This meant Sensus.UiTest was building, and it didn't have up to date packages with the other projects. I now have the build configuration set correctly on my windows machine. However, since I'd already gotten the project up to date I went ahead and committed the package changes.
The other change in this bundle was explicitly setting the memory available for the JRE. I guess the default JRE settings on Windows are different from Mac because out of the box I hit an OME when spinning up the Android emulator. I explicitly set the memory reservation to 1 GB and no longer have any issues.
I thought I'd just go ahead and push these up by themselves so we can merge them by themselves. That way, in the future, when I'm doing actual changes the diffs will look cleaner and won't include a bunch of extra stuff.