Bu 24 update sdk for beam saved location support #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 11, 2025 14:10
medhatphq
reviewed
Jul 14, 2025
| else: | ||
| from enum import StrEnum | ||
|
|
||
| # Python < 3.9 does not have Annotated in the enum module |
There was a problem hiding this comment.
remove in the enum module seems to be a copy/paste
medhatphq
reviewed
Jul 14, 2025
| else: | ||
| from typing import Annotated, Literal | ||
|
|
||
| # Python < 3.8 does not have Literal in the enum module |
There was a problem hiding this comment.
remove in the enum module
medhatphq
reviewed
Jul 14, 2025
| if sys.version_info < (3, 9): | ||
| from typing_extensions import Annotated | ||
| else: | ||
| from typing import Annotated, Literal |
There was a problem hiding this comment.
do you need to import Literal again here since you handled it further down on lines 23-26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.