-
-
Notifications
You must be signed in to change notification settings - Fork 127
Growing mesh case #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Growing mesh case #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is still a draft, but I had a quick look anyway, so I left some comments that I know are probably already on your list.
growing-mesh/README.md
Outdated
- A who runs first | ||
- B who runs second |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We so far avoid calling participants and data generic names, but try to relate to a specific physical domain and application use case. This is currently only partially described in the naming conventions.
Of course, this is fine for now (and fine for an integration test), but before merging, we should better have more descriptive names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They both represent the same mesh and don't model any physical behaviour.
Not sure what we would name them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a physical motivation for this scenario. We could borrow names there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pyhsical motivation is to couple a hydrogeological and geomechanical model and let them iterate until they agree on effective stress.
Without the iterative scheme, there is no correction and the geomechanical model doesn't have a function.
So, I cannot see obvious names that we can use here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But then we need to better express the motivation in the description and say that the modeling is (extremely) simplified, as is the case in general in our tutorials.
With the current formulation, it is a great integration test, but it looks a bit odd as a tutorial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the motivation and more details about the solver.
e322653
to
4ea4cd4
Compare
4ea4cd4
to
dcbe41c
Compare
48f2c5c
to
c7dd907
Compare
This PR adds a growing mesh case.
Two solvers define the same mesh, which grows at given points in time.
Inspiration for this case is the formation of additional residue layers on the floor of an ocean over time.
@MakisH is this how you envision the separate solver folder to work?
Checklist:
changelog-entries/<PRnumber>.md
.