-
-
Notifications
You must be signed in to change notification settings - Fork 76
replace default details marker with custom toggle arrows #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! Do you have screenshots of how this would look like when rendered? That would make the PR easier to review. |
The CI is failing to build the website from this PR: https://github.com/precice/precice.github.io/actions/runs/17377997579/job/49330210240?pr=582 |
The
The Ruby version is fixed in https://github.com/precice/precice.github.io/blob/master/.ruby-version You could try updating the version there and see what happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep the changes to the Gemfile
and Gemfile.lock
in a separate PR, if they are not needed for the actual feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BytePaul in the "Files changed" view (https://github.com/precice/precice.github.io/pull/582/files) I now see the changes of this PR and of #584 mixed together. It is important to keep the changes of each PR separate, so that each PR can be reviewed individually. Please drop the unrelated commits.
1a2e05e
to
3a76e6a
Compare
Replace default details marker with custom toggle arrows (▼/▲) and update Gemfile
Description
This PR introduces two improvements:
Custom toggle arrows for/
Gemfile update for compatibility