-
-
Notifications
You must be signed in to change notification settings - Fork 76
Remove yaml-cpp as a dependency of the CalculiX adapter #547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, provided that the update is released.
I will review the pending PRs, and we can then release everything together.
General question: how do we handle documentation of older versions? The YAML-cpp documentation is still relevant for everything prior to the latest/upcoming version. |
That's why I suggested a Assuming we don't want that for some reason, the current strategy is only relying on the exported PDF: https://precice.org/fundamentals-previous-versions.html |
Explaining how to install yaml cpp and how to set everything up is enough content for a subsection. It's too much for an alert/note.
So far, this versioning strategy has been regarding preCICE configuration etc. We never nailed down a strategy on how to handle adapter/binding/tooling versions. I also don't have a good idea on how to handle that. |
Let's continue in a separate issue for the general strategy: #548 |
I will implement the compatibility label for #548 and add one here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This information needs to be kept around as long as it is relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This system is anyway decommissioned, and the page is extremely outdated, so I would rather remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fsimonis the bottom of that page states that one can use CMake to build the adapter. Is this a relic of your past endeavors? This section should probably be removed.
Not sure how much of the rest of the content is relevant to anyone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated all pages to keep the information but add version context around it. Looks ready to merge for me.
We could additionally discuss on whether the SuperMUC page still makes sense to keep around, but I have added the context there as well.
In precice/calculix-adapter#143 the CalculiX adapter was changed to use the header-only YAML. Hence the information about yaml-cpp as a dependency needs to be removed.