Skip to content

Handle JSON string source maps returned from rollup plugins #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle JSON string source maps returned from rollup plugins #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-shrimps-hope.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'wmr': patch
---

Handle JSON string source maps returned from rollup plugins
12 changes: 12 additions & 0 deletions packages/wmr/src/lib/rollup-plugin-container.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,18 @@ export function createPluginContainer(plugins, opts = {}) {

logTransform(`${kl.dim(formatPath(id))} [${plugin.name}]`);
if (typeof result === 'object') {
if (typeof result.map === 'string') {
try {
result.map = JSON.parse(result.map);
} catch {
if (hasDebugFlag()) {
Copy link
Member

@marvinhagemeister marvinhagemeister Aug 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to wrap this with hasDebugFlag(). That check is already part of logTransform.

logTransform(kl.yellow(`Invalid source map JSON returned by plugin `) + kl.magenta(plugin.name));
}

result.map = undefined;
}
}

if (result.map) {
// Normalize source map sources URLs for the browser
result.map.sources = result.map.sources.map(s => {
Expand Down