Remove devtools module declaraction #1083
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't found a way to avoid getting the following error from the
preact/devtools
declaration in this file:I don't believe this declaration is really necessary though. Neither devtools.js nor debug.js have any exports so using syntax such as
import * as something from 'preact/debug';
wouldn't be correct usage. TypeScript only needs the module to be declared if you try to import something from it. Since the correct usage of these modules isimport 'preact/debug';
orrequire('preact/debug');
, we don't need to declare definitions for these modules. TypeScript handlesimport 'preact/debug';
andrequire('preact/debug');
fine without any definitions.P.S. it appears that error is because it isn't declared within a global scope (see microsoft/TypeScript#9748). However wrapping this declaration in a
declare global
leads to others errors. Instead of chasing that rabbit hole, I thought it made more sense to just remove it, given the rationale above.Thoughts?