Skip to content

Don't try to intercept links inside contenteditable #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't try to intercept links inside contenteditable #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ function delegateLinkHandler(e) {

let t = e.target;
do {
if (t.localName === 'a' && t.getAttribute('href')) {
if (t.localName === 'a' && t.getAttribute('href') && !t.isContentEditable) {
if (t.hasAttribute('data-native') || t.hasAttribute('native')) return;
// if link is handled by the router, prevent browser defaults
if (routeFromLink(t)) {
Expand Down
19 changes: 19 additions & 0 deletions test/dom.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
let onChange = jasmine.createSpy();
mount(
<div>
<div dangerouslySetInnerHTML={{ __html: `<a href="#foo">foo</a>` }} />

Check warning on line 108 in test/dom.test.js

View workflow job for this annotation

GitHub Actions / build_test 

Dangerous property 'dangerouslySetInnerHTML' found
<Router onChange={onChange}>
<div default />
</Router>
Expand All @@ -118,6 +118,25 @@
expect(onChange).not.toHaveBeenCalled();
expect(location.href).toContain('#foo');
});

it('should not intercept links inside contenteditable', () => {
let onChange = jasmine.createSpy();
mount(
<div>
<div contenteditable>
<a href="#foo">foo</a>
</div>
<Router onChange={onChange}>
<div default />
</Router>
</div>
);
onChange.calls.reset();
act(() => {
$('a').click();
});
expect(onChange).not.toHaveBeenCalled();
});
});

describe('Router', () => {
Expand Down
Loading