Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that official
check_yaml
hook throws aUnicodeDecodeError
in case of invalid file encoding without providing any details about the invalid yaml file. This makes it very difficult for the developer to figure out which file is causing the problem.Example of error stack-trace:
This PR improves the reliability of the
check_yaml
hook by ensuring it handles also YAML containing characters that violates file encoding.In case of
UnicodeDecodeError
the hook notify the error and prints a simple message to indicate the file path that generate the error.The same behaviour applies also in case of
ruamel.yaml.YAMLError
(obviously with a different error message).I made also a new unit test to complete the test coverage over my new changes.
Please, take a look on my little changes.
I hope this has been helpful and I look forward to hearing your feedback.