Create initial portfolio screen #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
commented
Jan 2, 2025
| <Story /> | ||
| </DripsyProvider> | ||
| </PraxI18nProvider> | ||
| <ReduxProvider> |
There was a problem hiding this comment.
Needed because <Balance />, which has a Storybook story, dispatches Redux actions
There was a problem hiding this comment.
Extracted from <HomeScreen />
There was a problem hiding this comment.
The action sheet here ^
TalDerei
approved these changes
Jan 6, 2025
|
|
||
| export default function PortfolioScreen() { | ||
| return <Text>PortfolioScreen</Text>; | ||
| const balances = useAppSelector(state => state.balances.balances); |
|
will add comments re: missing Figma elements in an upcoming PR! |
jessepinho
added a commit
that referenced
this pull request
Jan 6, 2025
* Create <List /> component * Extract PraxDripsyProvider * Set up Storybook to work with i18n; Install testing libs * Add XS icon size * Truncate text in ListItem * Create factories * Create TransactionList * Fix text overflow * Add screenHorizontalMargin * Create transactions state * Add transactions list to home screen * Add a primaryAction prop to List * Remove unused props * Remove unused var * Rework header components * Build out TransactionsScreen * Tweak comments * Add comments * Fix suffix * Add comment * Add RN Jest matchers * Update tests * Update args * Add comment * Reorganize and add comments * Early return * Create initial portfolio screen (#15) * Rename header * Extract BalanceAndActions component; use it in PortfolioScreen * Create store/type/factory for balances * Create balance UI in portfolio screen * Use more precise naming * Tweak factories * Wrap Storybook stories in <ReduxProvider /> * Fix ATOM mock data * Delete BalanceList stories for now * Build a simple AssetActionSheet * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-12-31.at.7.42.31.PM.mov
In this PR
<BalanceAndActions />component, for the shared UI between the Home and Portfolio screens