fix: settimeout trying to scroll when element is undefined #508
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when using multiple chrono charts in single component, while its loading if we switch tab, it will result in error as shown in screenshot.
Additional context
This is caused by the code
setTimeout(() => { const ele = horizontalContentRef.current as HTMLElement; ele.style.scrollBehavior = 'smooth'; ele.scrollLeft += cardLeft - contentLeft + cardWidth / 2 - contentWidth / 2; }, 100);
when the settimeout of some chrono gets executed, the element might be undefined as the page might have changed.
by adding if(ele) condition to make sure the element is present before initiating the scroll, we can solve this issue.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).