LibOQS integration

[h2parson]

I have added an integration directory which contain all additional files required for use of slh_dsa_c in the libOQS repository.

Additionally I have changed the maximum context size for prehash signing to 255 from 256 to get signature tests to pass in libOQS.

[mkannwischer]

Thanks! Can you move it to integration/liboqs, please? We may have more integrations in the future. Also please squash your commits, so that each commit corresponds to one logical change.

Don't we also need a list of files to be imported and compiler flags to be set? Something along the lines of https://github.com/pq-code-package/mlkem-native/blob/main/integration/liboqs/ML-KEM-768_META.yml?
It's probably a good idea to maintain that all in this repo in case files change in the future.

[h2parson]

Thanks! Can you move it to integration/liboqs, please? We may have more integrations in the future. Also please squash your commits, so that each commit corresponds to one logical change.

Don't we also need a list of files to be imported and compiler flags to be set? Something along the lines of https://github.com/pq-code-package/mlkem-native/blob/main/integration/liboqs/ML-KEM-768_META.yml? It's probably a good idea to maintain that all in this repo in case files change in the future.

Hi Matthias,
I can move this to integration/liboqs and squash the commit history.

As for including a list of files, I am currently pulling the tarball of the slh_dsa_c commit listed in libOQS so it will copy the entire repo over once without requiring a list of files to pull.
I also do not think that setting different compile options will be necessary as the parameter set can be specified through a variable at runtime.

[mkannwischer]

Thanks! Can you move it to integration/liboqs, please? We may have more integrations in the future. Also please squash your commits, so that each commit corresponds to one logical change.
Don't we also need a list of files to be imported and compiler flags to be set? Something along the lines of https://github.com/pq-code-package/mlkem-native/blob/main/integration/liboqs/ML-KEM-768_META.yml? It's probably a good idea to maintain that all in this repo in case files change in the future.

Hi Matthias, I can move this to integration/liboqs and squash the commit history.

Thanks!

As for including a list of files, I am currently pulling the tarball of the slh_dsa_c commit listed in libOQS so it will copy the entire repo over once without requiring a list of files to pull. I also do not think that setting different compile options will be necessary as the parameter set can be specified through a variable at runtime.

But we don't want all the files in slhdsa-c in liboqs? E.g., the test files shouldn't go into liboqs, but also the Makefile and other files shouldn't. How do you control which files get imported?

[h2parson]

Thanks! Can you move it to integration/liboqs, please? We may have more integrations in the future. Also please squash your commits, so that each commit corresponds to one logical change.
Don't we also need a list of files to be imported and compiler flags to be set? Something along the lines of https://github.com/pq-code-package/mlkem-native/blob/main/integration/liboqs/ML-KEM-768_META.yml? It's probably a good idea to maintain that all in this repo in case files change in the future.

Hi Matthias, I can move this to integration/liboqs and squash the commit history.

Thanks!

As for including a list of files, I am currently pulling the tarball of the slh_dsa_c commit listed in libOQS so it will copy the entire repo over once without requiring a list of files to pull. I also do not think that setting different compile options will be necessary as the parameter set can be specified through a variable at runtime.

But we don't want all the files in slhdsa-c in liboqs? E.g., the test files shouldn't go into liboqs, but also the Makefile and other files shouldn't. How do you control which files get imported?

That is true. I will rework the yml file to explicitly list these files.

[mkannwischer]

As for including a list of files, I am currently pulling the tarball of the slh_dsa_c commit listed in libOQS so it will copy the entire repo over once without requiring a list of files to pull. I also do not think that setting different compile options will be necessary as the parameter set can be specified through a variable at runtime.

But we don't want all the files in slhdsa-c in liboqs? E.g., the test files shouldn't go into liboqs, but also the Makefile and other files shouldn't. How do you control which files get imported?

That is true. I will rework the yml file to explicitly list these files.

Thanks!

Is this PR ready for review or are you planning further changes before it should be merged? If so please mark it as draft until it is ready.

[h2parson]

As for including a list of files, I am currently pulling the tarball of the slh_dsa_c commit listed in libOQS so it will copy the entire repo over once without requiring a list of files to pull. I also do not think that setting different compile options will be necessary as the parameter set can be specified through a variable at runtime.

But we don't want all the files in slhdsa-c in liboqs? E.g., the test files shouldn't go into liboqs, but also the Makefile and other files shouldn't. How do you control which files get imported?

That is true. I will rework the yml file to explicitly list these files.

Thanks!

Is this PR ready for review or are you planning further changes before it should be merged? If so please mark it as draft until it is ready.

I will mark it as a draft for now since my PR is not yet ready to merge on the libOQS side.

[mkannwischer]

Thanks @h2parson. The last two commits look good to me, but the PR contains a bunch of changes that look unintentional (the first 6 commits). You will also have to rebase on top of main.
Could you please clean that up and request a review again?

[mkannwischer]

LGTM. Thank you!