Skip to content

Conversation

@mkannwischer
Copy link
Contributor

@mkannwischer mkannwischer commented Nov 5, 2025

This PR ports part of pq-code-package/mlkem-native#1250

Currently we are using custom AMIs for the CBMC tests. The only
reason for using custom AMI is that require a disk of larger than
the default 8 GB.
This commit switches to default AMIs and instead uses the ec2_volume_size
argument of the ec2-github-runner action.

@mkannwischer
Copy link
Contributor Author

Proof times are increased 6 -> 10mins; 6->11mins; 8->12mins when switching from c7g.4xlarge -> r8g.xlarge. This is still a net saving in proof cost with current EC2 pricing: https://aws.amazon.com/ec2/pricing/on-demand/.

Let me try r8g.2xlarge.

@mkannwischer mkannwischer force-pushed the cbmc-r8g branch 2 times, most recently from c43e68d to e5b51f4 Compare November 10, 2025 02:18
Currently we are using custom AMIs for the CBMC tests. The only
reason for using custom AMI is that require a disk of larger than
the default 8 GB.
This commit switches to default AMIs and instead uses the ec2_volume_size
argument of the ec2-github-runner action.

Signed-off-by: Matthias J. Kannwischer <[email protected]>
@mkannwischer mkannwischer changed the title CI: Switch to r8g.xlarge for CBMC proofs CI: Do not use custom AMI for CBMC runners Nov 10, 2025
@mkannwischer
Copy link
Contributor Author

Proof times are increased 6 -> 10mins; 6->11mins; 8->12mins when switching from c7g.4xlarge -> r8g.xlarge. This is still a net saving in proof cost with current EC2 pricing: https://aws.amazon.com/ec2/pricing/on-demand/.

Let me try r8g.2xlarge.

Let's stick to c7g.4xlarge for now. If cost becomes an issue at some point, we can consider switching.

@mkannwischer mkannwischer marked this pull request as ready for review November 10, 2025 07:48
@mkannwischer mkannwischer requested a review from a team as a code owner November 10, 2025 07:48
@mkannwischer mkannwischer merged commit a88784e into main Nov 10, 2025
247 checks passed
@mkannwischer mkannwischer deleted the cbmc-r8g branch November 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants