Skip to content

Update to nixpkgs 25.05 #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2025
Merged

Update to nixpkgs 25.05 #286

merged 2 commits into from
May 25, 2025

Conversation

mkannwischer
Copy link
Contributor

@mkannwischer mkannwischer commented May 24, 2025

Similar to pq-code-package/mlkem-native#1041
Additionally, refactoring the CI to align with mlkem-native

NixOS 25.05 has been released yesterday bringing various version updates also to nixpkgs.

Notable changes for us are:

  • Default clang/llvm is now 19; we switch to the default in the core shells
  • Default gcc is now 14; we switch to it in the core shells
  • gcc 7, zig_0_10, zig_0_11 are not longer supported in 25.05; we instead
    take it from nixpkgs 24.05
  • zig_0_14 has been added; we test in CI now as well
  • Unicorn and protobuf versions are now compatible with SLOTHY simpliying the
    build
  • z3 has been updated to 4.15.0; we take it from 25.05
  • clang_20, bitwuzla, qemu now have suitable versions in 25.05; we no longer
    need to take them from unstable.
  • The CBMC build in nixpkgs includes 3 patches now instead of 2. The third patch is not compatible and not needed for cbmc 6.6.0. We, hence, have to copy the first two patches and apply them locally. This makes the patch slightly more complicated.
  • A few dependency updates for which we do not require specific versions

Notable changes are:
 - Default clang/llvm is now 19; we switch to the default in the core shells
 - Default gcc is now 14; we switch to it in the core shells
 - gcc 7, zig_0_10, zig_0_11 are not longer supported in 25.05; we instead
   take it from nixpkgs 24.05
 - zig_0_14 has been added; we test in CI now as well
 - Unicorn and protobuf versions are now compatible with SLOTHY simpliying the
   build
 - z3 has been updated to 4.15.0; we take it from 25.05
 - clang_20, bitwuzla, qemu now have suitable versions in 25.05; we no longer
   need to take them from unstable.
 - The upstream CBMC nixpkgs build (6.4.1) uses 3 patches instead of 2 used
   before. Since we are using 6.6.0, we do not require the third patch.
   We, hence, have to overwrite the patches here locally and use on the the
   first two. This slighty complicates our flake.
 - A few dependency updates for which we do not require specific versions

Signed-off-by: Matthias J. Kannwischer <[email protected]>

.
This commit refactors our CI to split it in different workflows:
Base, Extended, CBMC, Nix.

This way we can first run the base CI before invoking the other workflows.
It also allows the Extended and CBMC workflows to wait for the nix cache
to be built in case it needs to change.

Signed-off-by: Matthias J. Kannwischer <[email protected]>
@mkannwischer mkannwischer marked this pull request as ready for review May 24, 2025 07:30
@mkannwischer mkannwischer requested a review from a team as a code owner May 24, 2025 07:30
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac Mini (M1, 2020) benchmarks (opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 100251 cycles 99918 cycles 1.00
ML-DSA-44 sign 225197 cycles 132053 cycles 1.71
ML-DSA-44 verify 102331 cycles 102131 cycles 1.00
ML-DSA-65 keypair 181580 cycles 175471 cycles 1.03
ML-DSA-65 sign 365102 cycles 363936 cycles 1.00
ML-DSA-65 verify 168248 cycles 167106 cycles 1.01
ML-DSA-87 keypair 296181 cycles 293910 cycles 1.01
ML-DSA-87 sign 504503 cycles 502464 cycles 1.00
ML-DSA-87 verify 293607 cycles 289463 cycles 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Mac Mini (M1, 2020) benchmarks (opt)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 sign 225197 cycles 132053 cycles 1.71
ML-DSA-65 keypair 181580 cycles 175471 cycles 1.03

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mac Mini (M1, 2020) benchmarks (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 115176 cycles 116518 cycles 0.99
ML-DSA-44 sign 354629 cycles 369399 cycles 0.96
ML-DSA-44 verify 124716 cycles 127125 cycles 0.98
ML-DSA-65 keypair 202224 cycles 200041 cycles 1.01
ML-DSA-65 sign 563362 cycles 585208 cycles 0.96
ML-DSA-65 verify 199695 cycles 202110 cycles 0.99
ML-DSA-87 keypair 324046 cycles 325439 cycles 1.00
ML-DSA-87 sign 727099 cycles 751554 cycles 0.97
ML-DSA-87 verify 332110 cycles 334484 cycles 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A76 (Raspberry Pi 5) benchmarks (opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 195575 cycles 195964 cycles 1.00
ML-DSA-44 sign 468465 cycles 468523 cycles 1.00
ML-DSA-44 verify 198397 cycles 198404 cycles 1.00
ML-DSA-65 keypair 349934 cycles 349221 cycles 1.00
ML-DSA-65 sign 768678 cycles 767136 cycles 1.00
ML-DSA-65 verify 328465 cycles 330684 cycles 0.99
ML-DSA-87 keypair 574444 cycles 573746 cycles 1.00
ML-DSA-87 sign 1041848 cycles 1042716 cycles 1.00
ML-DSA-87 verify 561518 cycles 560487 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A76 (Raspberry Pi 5) benchmarks (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 214561 cycles 214664 cycles 1.00
ML-DSA-44 sign 629091 cycles 629503 cycles 1.00
ML-DSA-44 verify 228854 cycles 228902 cycles 1.00
ML-DSA-65 keypair 376539 cycles 375527 cycles 1.00
ML-DSA-65 sign 1011106 cycles 1010760 cycles 1.00
ML-DSA-65 verify 370646 cycles 372563 cycles 0.99
ML-DSA-87 keypair 616081 cycles 610537 cycles 1.01
ML-DSA-87 sign 1358227 cycles 1327026 cycles 1.02
ML-DSA-87 verify 629214 cycles 618897 cycles 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 3rd gen (c6i)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 152159 cycles 152817 cycles 1.00
ML-DSA-44 sign 443917 cycles 444730 cycles 1.00
ML-DSA-44 verify 161191 cycles 162011 cycles 0.99
ML-DSA-65 keypair 254924 cycles 254947 cycles 1.00
ML-DSA-65 sign 691334 cycles 691685 cycles 1.00
ML-DSA-65 verify 254704 cycles 254964 cycles 1.00
ML-DSA-87 keypair 424741 cycles 426582 cycles 1.00
ML-DSA-87 sign 916187 cycles 918576 cycles 1.00
ML-DSA-87 verify 427655 cycles 429321 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A72 (Raspberry Pi 4) benchmarks (opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 263864 cycles 262456 cycles 1.01
ML-DSA-44 sign 737119 cycles 662663 cycles 1.11
ML-DSA-44 verify 265343 cycles 264971 cycles 1.00
ML-DSA-65 keypair 490890 cycles 492613 cycles 1.00
ML-DSA-65 sign 1071394 cycles 1067660 cycles 1.00
ML-DSA-65 verify 441340 cycles 440033 cycles 1.00
ML-DSA-87 keypair 765572 cycles 766459 cycles 1.00
ML-DSA-87 sign 1446787 cycles 1473228 cycles 0.98
ML-DSA-87 verify 747138 cycles 749770 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Arm Cortex-A72 (Raspberry Pi 4) benchmarks (opt)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 sign 737119 cycles 662663 cycles 1.11

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 4th gen (c7i)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 98554 cycles 98448 cycles 1.00
ML-DSA-44 sign 284603 cycles 283034 cycles 1.01
ML-DSA-44 verify 102734 cycles 103610 cycles 0.99
ML-DSA-65 keypair 165667 cycles 166302 cycles 1.00
ML-DSA-65 sign 448894 cycles 450712 cycles 1.00
ML-DSA-65 verify 162424 cycles 163487 cycles 0.99
ML-DSA-87 keypair 274091 cycles 275107 cycles 1.00
ML-DSA-87 sign 586311 cycles 588169 cycles 1.00
ML-DSA-87 verify 272388 cycles 272413 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 3rd gen (c6a)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 136080 cycles 135595 cycles 1.00
ML-DSA-44 sign 437806 cycles 460077 cycles 0.95
ML-DSA-44 verify 147327 cycles 146923 cycles 1.00
ML-DSA-65 keypair 224004 cycles 226813 cycles 0.99
ML-DSA-65 sign 673585 cycles 676423 cycles 1.00
ML-DSA-65 verify 227490 cycles 229912 cycles 0.99
ML-DSA-87 keypair 374473 cycles 374438 cycles 1.00
ML-DSA-87 sign 885975 cycles 886683 cycles 1.00
ML-DSA-87 verify 382937 cycles 382591 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 3rd gen (c6i) (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 152089 cycles 152797 cycles 1.00
ML-DSA-44 sign 445053 cycles 444938 cycles 1.00
ML-DSA-44 verify 161201 cycles 161573 cycles 1.00
ML-DSA-65 keypair 254769 cycles 254877 cycles 1.00
ML-DSA-65 sign 692201 cycles 692396 cycles 1.00
ML-DSA-65 verify 254543 cycles 254956 cycles 1.00
ML-DSA-87 keypair 424496 cycles 426162 cycles 1.00
ML-DSA-87 sign 917348 cycles 918959 cycles 1.00
ML-DSA-87 verify 427407 cycles 429545 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intel Xeon 4th gen (c7i) (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 98530 cycles 98328 cycles 1.00
ML-DSA-44 sign 281980 cycles 284172 cycles 0.99
ML-DSA-44 verify 102773 cycles 103502 cycles 0.99
ML-DSA-65 keypair 165561 cycles 165342 cycles 1.00
ML-DSA-65 sign 448347 cycles 450605 cycles 0.99
ML-DSA-65 verify 163621 cycles 163019 cycles 1.00
ML-DSA-87 keypair 274182 cycles 274337 cycles 1.00
ML-DSA-87 sign 586808 cycles 588869 cycles 1.00
ML-DSA-87 verify 272306 cycles 272426 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 4th gen (c7a)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 119678 cycles 119880 cycles 1.00
ML-DSA-44 sign 369235 cycles 370516 cycles 1.00
ML-DSA-44 verify 128425 cycles 128235 cycles 1.00
ML-DSA-65 keypair 199468 cycles 200258 cycles 1.00
ML-DSA-65 sign 562970 cycles 561922 cycles 1.00
ML-DSA-65 verify 200909 cycles 200810 cycles 1.00
ML-DSA-87 keypair 331857 cycles 331563 cycles 1.00
ML-DSA-87 sign 734351 cycles 733607 cycles 1.00
ML-DSA-87 verify 334435 cycles 334886 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 3rd gen (c6a) (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 136018 cycles 135523 cycles 1.00
ML-DSA-44 sign 437353 cycles 437522 cycles 1.00
ML-DSA-44 verify 147690 cycles 146988 cycles 1.00
ML-DSA-65 keypair 224031 cycles 226865 cycles 0.99
ML-DSA-65 sign 673303 cycles 676891 cycles 0.99
ML-DSA-65 verify 227442 cycles 229530 cycles 0.99
ML-DSA-87 keypair 374773 cycles 374111 cycles 1.00
ML-DSA-87 sign 886050 cycles 885569 cycles 1.00
ML-DSA-87 verify 382270 cycles 382125 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMD EPYC 4th gen (c7a) (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 119869 cycles 119744 cycles 1.00
ML-DSA-44 sign 369550 cycles 369650 cycles 1.00
ML-DSA-44 verify 128139 cycles 128008 cycles 1.00
ML-DSA-65 keypair 199599 cycles 200092 cycles 1.00
ML-DSA-65 sign 560671 cycles 561317 cycles 1.00
ML-DSA-65 verify 200711 cycles 200864 cycles 1.00
ML-DSA-87 keypair 332099 cycles 331646 cycles 1.00
ML-DSA-87 sign 734651 cycles 734232 cycles 1.00
ML-DSA-87 verify 334643 cycles 334633 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A55 (Snapdragon 888) benchmarks (opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 380353 cycles 379448 cycles 1.00
ML-DSA-44 sign 1004753 cycles 1001117 cycles 1.00
ML-DSA-44 verify 398579 cycles 397880 cycles 1.00
ML-DSA-65 keypair 661430 cycles 658158 cycles 1.00
ML-DSA-65 sign 1625371 cycles 1625426 cycles 1.00
ML-DSA-65 verify 640087 cycles 638217 cycles 1.00
ML-DSA-87 keypair 1122235 cycles 1094113 cycles 1.03
ML-DSA-87 sign 2245555 cycles 2189695 cycles 1.03
ML-DSA-87 verify 1097855 cycles 1079077 cycles 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton4

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 119498 cycles 119681 cycles 1.00
ML-DSA-44 sign 270724 cycles 270559 cycles 1.00
ML-DSA-44 verify 120262 cycles 120433 cycles 1.00
ML-DSA-65 keypair 207787 cycles 207140 cycles 1.00
ML-DSA-65 sign 432250 cycles 431516 cycles 1.00
ML-DSA-65 verify 198165 cycles 197678 cycles 1.00
ML-DSA-87 keypair 351043 cycles 350590 cycles 1.00
ML-DSA-87 sign 594891 cycles 595201 cycles 1.00
ML-DSA-87 verify 337779 cycles 337811 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton3

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 126466 cycles 126641 cycles 1.00
ML-DSA-44 sign 285865 cycles 285808 cycles 1.00
ML-DSA-44 verify 127490 cycles 127747 cycles 1.00
ML-DSA-65 keypair 219505 cycles 220285 cycles 1.00
ML-DSA-65 sign 465977 cycles 467165 cycles 1.00
ML-DSA-65 verify 210309 cycles 211176 cycles 1.00
ML-DSA-87 keypair 374034 cycles 373971 cycles 1.00
ML-DSA-87 sign 643579 cycles 643614 cycles 1.00
ML-DSA-87 verify 360473 cycles 362774 cycles 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton2

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 195739 cycles 195697 cycles 1.00
ML-DSA-44 sign 468613 cycles 468646 cycles 1.00
ML-DSA-44 verify 198612 cycles 198261 cycles 1.00
ML-DSA-65 keypair 350123 cycles 349282 cycles 1.00
ML-DSA-65 sign 768963 cycles 767664 cycles 1.00
ML-DSA-65 verify 328494 cycles 329028 cycles 1.00
ML-DSA-87 keypair 574600 cycles 573783 cycles 1.00
ML-DSA-87 sign 1042810 cycles 1043660 cycles 1.00
ML-DSA-87 verify 563150 cycles 561129 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton4 (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 132258 cycles 132412 cycles 1.00
ML-DSA-44 sign 386194 cycles 386507 cycles 1.00
ML-DSA-44 verify 140937 cycles 141130 cycles 1.00
ML-DSA-65 keypair 226554 cycles 225456 cycles 1.00
ML-DSA-65 sign 625026 cycles 624356 cycles 1.00
ML-DSA-65 verify 227445 cycles 227004 cycles 1.00
ML-DSA-87 keypair 375616 cycles 375457 cycles 1.00
ML-DSA-87 sign 812289 cycles 813146 cycles 1.00
ML-DSA-87 verify 375388 cycles 383996 cycles 0.98

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton3 (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 138775 cycles 138903 cycles 1.00
ML-DSA-44 sign 392513 cycles 391978 cycles 1.00
ML-DSA-44 verify 146669 cycles 146832 cycles 1.00
ML-DSA-65 keypair 236645 cycles 236812 cycles 1.00
ML-DSA-65 sign 627329 cycles 626252 cycles 1.00
ML-DSA-65 verify 237032 cycles 236981 cycles 1.00
ML-DSA-87 keypair 398181 cycles 398261 cycles 1.00
ML-DSA-87 sign 828525 cycles 828830 cycles 1.00
ML-DSA-87 verify 397049 cycles 397726 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@oqs-bot oqs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Graviton2 (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 214633 cycles 214424 cycles 1.00
ML-DSA-44 sign 629301 cycles 629455 cycles 1.00
ML-DSA-44 verify 228992 cycles 229049 cycles 1.00
ML-DSA-65 keypair 376295 cycles 375590 cycles 1.00
ML-DSA-65 sign 1011213 cycles 1011336 cycles 1.00
ML-DSA-65 verify 370310 cycles 370873 cycles 1.00
ML-DSA-87 keypair 616506 cycles 611172 cycles 1.01
ML-DSA-87 sign 1359217 cycles 1330825 cycles 1.02
ML-DSA-87 verify 630299 cycles 619191 cycles 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A72 (Raspberry Pi 4) benchmarks (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 296141 cycles 296615 cycles 1.00
ML-DSA-44 sign 1004651 cycles 966468 cycles 1.04
ML-DSA-44 verify 317564 cycles 319290 cycles 0.99
ML-DSA-65 keypair 540508 cycles 537927 cycles 1.00
ML-DSA-65 sign 1528365 cycles 1510193 cycles 1.01
ML-DSA-65 verify 517341 cycles 514869 cycles 1.00
ML-DSA-87 keypair 831265 cycles 833700 cycles 1.00
ML-DSA-87 sign 1990067 cycles 1939495 cycles 1.03
ML-DSA-87 verify 847540 cycles 847955 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Arm Cortex-A72 (Raspberry Pi 4) benchmarks (no-opt)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 sign 1004651 cycles 966468 cycles 1.04

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arm Cortex-A55 (Snapdragon 888) benchmarks (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 471042 cycles 470053 cycles 1.00
ML-DSA-44 sign 1783700 cycles 1776230 cycles 1.00
ML-DSA-44 verify 539830 cycles 539372 cycles 1.00
ML-DSA-65 keypair 787111 cycles 784497 cycles 1.00
ML-DSA-65 sign 2824906 cycles 2815347 cycles 1.00
ML-DSA-65 verify 836435 cycles 835790 cycles 1.00
ML-DSA-87 keypair 1287623 cycles 1273300 cycles 1.01
ML-DSA-87 sign 3579291 cycles 3552014 cycles 1.01
ML-DSA-87 verify 1363714 cycles 1349518 cycles 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SpacemiT K1 8 (Banana Pi F3) benchmarks (no-opt)

Benchmark suite Current: 263f4c9 Previous: a1ad592 Ratio
ML-DSA-44 keypair 950692 cycles 948544 cycles 1.00
ML-DSA-44 sign 3672394 cycles 3669784 cycles 1.00
ML-DSA-44 verify 1075486 cycles 1075755 cycles 1.00
ML-DSA-65 keypair 1575026 cycles 1563457 cycles 1.01
ML-DSA-65 sign 5852199 cycles 5839467 cycles 1.00
ML-DSA-65 verify 1699533 cycles 1698569 cycles 1.00
ML-DSA-87 keypair 2535030 cycles 2539499 cycles 1.00
ML-DSA-87 sign 7241256 cycles 7264583 cycles 1.00
ML-DSA-87 verify 2702831 cycles 2701398 cycles 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@hanno-becker
Copy link
Contributor

Thank you also for the CI restructuring, @mkannwischer !

@hanno-becker hanno-becker merged commit 062f811 into main May 25, 2025
123 checks passed
@hanno-becker hanno-becker deleted the nix25.05 branch May 25, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to z3 4.15.0
3 participants