Allow clearing raw tables #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the definition for
RawTableto include aclearstring, which users can set to e.g.DELETE FROM tbl WHERE id = (SELECT min(id) FROM tbl); TRUNCATE tblto implement aclearoperation on that table.When
powersync_clear()is executed, we consider clear statements attached to raw tables and run them. Because we're not passing the database schema topowersync_clear, I've changedpowersync_replace_schema()to remember the current schema in theDatabaseState. This allowspowersync_clearto inspect raw tables.I've also refactored the core extension to avoid atomics. Using atomics makes parts of the code appear thread-safe, it very much isn't and we assume connections aren't used across threads concurrently. So, we may as well be explicit and slightly reduce code size by replacing
ArcwithRcandAtomicBoolwithCell<bool>.