Allow binary data in HTTP streams #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 44403fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
force-pushed
the
binary-http-sync
branch
from
44403fd to
1837874
Compare
rkistner
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for serving sync lines in BSON format through
/sync/stream. The behavior is opt-in and will only be enabled when there's anAcceptheader and that header indicates a preference for theapplication/vnd.powersync.bson-streamcontent type.This will allow the transport of binary data without the use of RSocket/Websockets, which may be something we need if we want to primarily use binary sync lines in the future (since RSocket on Dart continues to be uncertain).
When serving lines as BSON, we will simply concatenate them for the stream. Since the documents are length-prefixed, clients can split them fairly easily (see powersync-ja/powersync.dart#312, which I've used to test this).