Enable macOS support #141
Merged
Enable macOS support #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: We're still kind of waiting for touchlab/SQLiter#124 to resolve macOS linker errors, but I've verified that Swift SDK tests pass on macOS with those SQLiter changes. I've also applied a dependency override when building our xcframework for Kotlin, so we can use this to publish our other packages without changes while using the patched dependency to build the Swift SDK.
Now that we have figured out how to link SQLite statically, this PR does the few remaining things required for macOS support:
:compose(since compose multiplatform doesn't have stable native macOS support yet).iossource sets intoappletargets so that they're used on all Apple platforms (iOS and macOS).