Pull request for old stuff #17
Open
+2,029
−773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erColumns * Better examples
* Add Keyspace::removeColumn variant with no super_column_name in signature * Extend examples/simple.cc with more and better examples
(in case libcassandra is in /usr on the build machine)
Add updated libtool-relared m4's.
This reverts commit 48ce0c1.
Padraig's refactoring (moving lots of methods from Keyspace to Cassandra), a couple of my changes were lost. To be re-done in next commit Conflicts: .gitignore examples/get_drizzle_data.cc examples/simple.cc libcassandra/cassandra.cc libcassandra/cassandra_factory.cc libcassandra/keyspace.cc libcassandra/keyspace.h libcassandra/keyspace_factory.cc libgenthrift/Cassandra.cpp libgenthrift/Cassandra.h libgenthrift/Cassandra_server.skeleton.cpp libgenthrift/cassandra_constants.cpp libgenthrift/cassandra_types.h m4/ltversion.m4 m4/pandora_have_thrift.m4
…lace getSliceNames and getSliceRange with getColumns and getSuperColumns
…ement connect/send/receive timeout support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Padraig
To follow up on an old email discussion we had (subject "More API changes" from May 2010)
I had done these changes we discussed, but with the recent changes in the 0.7/master branch they were lost.
I pulled your master and re-implemented these changes, along with a new feature I've had in my branch for a while (Connect, read, write timeout support).
If you find them useful it'd be good if you can pull them into your branch, as it seems out of all the github forks yours is the most active/authoritative/up to date.
Unrelated 1:
Regarding my (very old) "libcassie" branch (C library for cassandra), I'm actually using it in production in my company, and have very recently started a child branch to bring it up to speed with your 0.7 changes.
Once your 0.7 branch/master stabilizes I'll aim for 100% API coverage of libcassandra in libcassie, then I'll offer it up for public consumption (perhaps even bubble up to master in my repo / yours).
Unrelated 2:
Any C++ books you recommend for a C programmer ? I still find C++ syntax, references, shared pointers and other language constructs fairly challenging.
Thank you, and keep up the great work :)