Skip to content

Conversation

parthverma1
Copy link

@parthverma1 parthverma1 commented Oct 7, 2025

PR Checklist:

  • I have run npm test locally and all tests are passing.
  • I have added/updated tests for any new behavior.
  • If this is a significant change, an issue has already been created where the problem / solution was discussed: [N/A, or add link to issue here]

PR Description

Adds support for SSL Keylogging

@parthverma1 parthverma1 requested a review from Copilot October 8, 2025 21:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds SSL session key logging functionality to the request library through a new keyLog option, enabling users to capture TLS session keys for debugging purposes.

  • Adds keyLog option support for capturing SSL session keys to a specified file
  • Integrates the option into the agent configuration and connection pooling logic
  • Updates documentation to describe the new feature

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
request.js Implements keyLog option handling, agent configuration, and socket event listener for SSL key capture
README.md Documents the new keyLog option in the API reference
Comments suppressed due to low confidence (1)

request.js:1

  • The documentation should clarify that keyLog accepts a file path (string) and specify the format of the captured SSL session keys (typically NSS key log format).
'use strict'

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants