Use xdg-open instead of open for opening preview files
#727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: - When a user runs `./preview` script to preview the extraction result, the script executes the `open` command regardless of the current operating system. As a result, the command fails on Linux. Modifications: - Use `xdg-open` instead of `open` in Linux to open a file. - Log a message in other operating systems. Result: - Preview files are open automatically as expected in Linux.
|
Gentle ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
./previewscript to preview the extraction result, the script executes theopencommand regardless of the current operating system. As a result, the command fails on Linux.Modifications:
xdg-openinstead ofopenin Linux to open a file.Result: