-
Notifications
You must be signed in to change notification settings - Fork 487
feat: Add pg18beta3 container #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
based on trixie as debian-bulleye is getting old
( @thomasboussekey ) Thank you for the PR! 1.) 2.) 3.)
|
Thanks @ImreSamu , fix in progress! For 1️⃣ , it should be named 18beta3-master, no? For 2️⃣ , folder has been renamed For 3️⃣ , for tomorrow 😪 |
Yes, correct.
Great! |
In the meantime, PostGIS 3.6.0rc1 has also been released (2025/08/18): If possible, could you also update: Of course, no problem if you prefer to skip these changes in this PR - I can add them later myself. Thanks in advance! |
@ImreSamu should the script use this location, in order to download postgis 3.6rc1? |
I’m not an expert either 🙂 Traditionally we use
If you’re interested in following the The Debian experimental package So my preference would be to keep the current conservative approach,
So we should wait until it appears on And thanks a lot for updating the images! When your changes are ready for another review, please let us know. |
@ImreSamu , it looks good now! I managed to fix Pg18beta3 Dockerfile generation 😅 |
Thank you for this excellent work! The changes are looking really good overall. I've spotted two minor issues that would be worth addressing:
What's working brilliantly:
These are just small housekeeping items, and the core functionality looks spot on. |
.github/workflows/main.yml
Outdated
variant: alpine | ||
runner-platform: 'ubuntu-24.04-arm' | ||
|
||
- postgres: 18beta3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate entries - the original matrix already includes these combinations.
I think these can be removed.
- 18beta3-3.5-default - 'ubuntu-24.04'
- 18beta3-3.5-default - 'ubuntu-24.04-arm'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question about the variant
key 🤔
... trying something 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed commit 53506a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌
[Docker PostGIS CI](https://github.com/postgis/docker-postgis/actions/runs/17172851282/workflow)
Error when evaluating 'runs-on' for job 'make-docker-images'. .github/workflows/main.yml (Line: 33, Col: 14): Unexpected value ''
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting, not clever enough to understand strategy.matrix.include
logic
README.md
Outdated
@@ -62,8 +62,11 @@ Recommended versions for new users are: `postgis/postgis:17-3.5`, `postgis/postg | |||
| DockerHub image | Dockerfile | OS | Postgres | PostGIS | | |||
| --------------- | ---------- | -- | -------- | ------- | | |||
| [postgis/postgis:16-master](https://registry.hub.docker.com/r/postgis/postgis/tags?page=1&name=16-master) | [Dockerfile](https://github.com/postgis/docker-postgis/blob/master/16-master/Dockerfile) | debian:bullseye | 16 | development: postgis, geos, proj, gdal | | |||
| [postgis/postgis:17-3.6.0alpha1-alpine](https://registry.hub.docker.com/r/postgis/postgis/tags?page=1&name=17-3.6.0alpha1-alpine) | [Dockerfile](https://github.com/postgis/docker-postgis/blob/master/17-3.6.0alpha1/alpine/Dockerfile) | alpine:3.22 | 17 | 3.6.0alpha1 | | |||
| [postgis/postgis:17-3.6.0beta1-alpine](https://registry.hub.docker.com/r/postgis/postgis/tags?page=1&name=17-3.6.0beta1-alpine) | [Dockerfile](https://github.com/postgis/docker-postgis/blob/master/17-3.6.0beta1/alpine/Dockerfile) | alpine:3.22 | 17 | 3.6.0beta1 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postgis/postgis:17-3.6.0beta1-alpine
This row was included because of the 17-3.6.0beta1
directory, but we're no longer building beta1
, only rc1
.
Once the 17-3.6.0beta1
directory is removed, ./update.sh
will no longer generate this line in the log test markdown section.
based on trixie as debian-bulleye is getting old