feat: Implement dynamic navs #90

cpsievert · 2022-02-17T23:59:19Z

Closes #89
Closes #99
Closes #1793
Closes #499

TODO

Turn show/hide into update_nav_panel
~~Does it make sense for their to be a ns() method on the Session/ModuleSession?~~ Edit @jcheng5 2023-05-22: I think resolve_id is how this works now.
Rename
Clean up docstrings
Update Express impl
Test that dynamic navs work in modules
Test that string removal works in nav menu, remove and add
Write e2e tests for the examples
[? ] Add nav_prepend and nav_append that are thin wrappers over nav_insert; takes too much thought to achieve these 99% cases otherwise
~ Edit @elnelson575 TBD here, @cpsievert is pondering

shiny/_modules.py

tests/playwright/shiny/components/dynamic_navs/app.py

tests/playwright/shiny/components/dynamic_navs/test_navs_dynamic.py

shiny/api-examples/update_nav_panel/app-core.py

shiny/api-examples/update_nav_panel/app-express.py

…amic-navs

shiny/api-examples/insert_nav_panel/app-core.py

shiny/api-examples/insert_nav_panel/app-express.py

shiny/ui/_navs_dynamic.py

…amic-navs

CHANGELOG.md

shiny/ui/_navs_dynamic.py

Co-authored-by: Carson Sievert <[email protected]>

cpsievert · 2025-07-31T17:16:18Z

LGTM 👍 . Please merge when green.

cpsievert force-pushed the dynamic-navs branch 3 times, most recently from 75581bd to 3611c13 Compare February 24, 2022 21:30

cpsievert force-pushed the dynamic-navs branch 2 times, most recently from 63e314d to 94dab30 Compare March 1, 2022 23:25

cpsievert mentioned this pull request Mar 2, 2022

Attach metadata about HTMLDependency()'s in the rendered document posit-dev/py-htmltools#22

Merged

cpsievert force-pushed the dynamic-navs branch 4 times, most recently from 2eab208 to e3f139c Compare March 3, 2022 18:44

cpsievert force-pushed the dynamic-navs branch 2 times, most recently from 942604f to c923440 Compare April 26, 2022 17:24

cpsievert changed the base branch from main to server-side-navs April 26, 2022 17:24

cpsievert force-pushed the server-side-navs branch from ea6dddc to ecbe0af Compare April 26, 2022 17:25

cpsievert force-pushed the dynamic-navs branch 2 times, most recently from d627256 to 2eaebf8 Compare April 26, 2022 17:27

cpsievert force-pushed the server-side-navs branch from ecbe0af to bfdc2e9 Compare April 26, 2022 19:36

cpsievert force-pushed the dynamic-navs branch from 2eaebf8 to f2a8c6a Compare April 26, 2022 19:38

cpsievert force-pushed the server-side-navs branch from f228178 to 0bec791 Compare April 26, 2022 20:58

cpsievert force-pushed the dynamic-navs branch 2 times, most recently from 05644ec to e5b2542 Compare April 26, 2022 21:13

cpsievert commented Apr 26, 2022

View reviewed changes

shiny/_modules.py Outdated Show resolved Hide resolved

cpsievert force-pushed the dynamic-navs branch 6 times, most recently from 8d5dbc6 to affed80 Compare April 27, 2022 21:47

cpsievert changed the base branch from server-side-navs to main April 28, 2022 22:50

cpsievert force-pushed the dynamic-navs branch from affed80 to 46a4176 Compare April 28, 2022 22:54

Updating to remove top level

b20faac