python: do not override root logger #7743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding a handler for
""
, we were effectively pushing all logs to a file, including the user's. I've removed the root logger and instead added a few other handlers to capture logs.This change does expose us to a much higher likelihood of our logs leaking into the console.
Eg, the added handlers were after observing
positron._vendor.pygls.protocol.json_rpc
will send out logs if you run something likeimport xyzabc
, and theComm
logs were leaking if there is an error in the comms.Related issue in Jupyter, where they needed to handle
tornado
logs jupyter/notebook#1397Release Notes
New Features
Bug Fixes
QA Notes
it's worth it to try to force a few other errors, to make sure we don't need to add other handlers.