Skip to content

Conversation

@sharon-wang
Copy link
Member

@sharon-wang sharon-wang commented Nov 17, 2025

Summary

image

Approach

  • each provider's resolveModels() method now calls retrieveModelsFromConfig() to check for statically defined models via positron.assistant.configuredModels or hardcoded models, then retrieveModelsFromApi() to dynamically retrieve the model listing if applicable for the provider
  • move some duplicated code to shared util files modelDefinitions.ts and modelResolutionHelpers.ts
  • continues some refactoring to incrementally work towards Assistant: reorg/refactor provider handling #10532

Release Notes

New Features

QA Notes

- add positron.assistant.configuredModels setting to allow users to statically configure model settings per provider, which overrides dynamic model resolution
- update and add tests around model resolution
@github-actions
Copy link

github-actions bot commented Nov 17, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Comment on lines -1049 to -1054
// Update a stale model configuration to the latest defaults
const models = availableModels.get('amazon-bedrock')?.map(m => m.identifier) || [];
if (!(_config.model in models)) {
_config.name = AWSLanguageModel.source.defaults.name;
_config.model = AWSLanguageModel.source.defaults.model;
}
Copy link
Member Author

@sharon-wang sharon-wang Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed this as we no longer use the hardcoded model listing, as we've switched to using the Bedrock SDK to dynamically retrieve the models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants