Fix axe-core button-name violation on code-block copy buttons#233
Merged
Fix axe-core button-name violation on code-block copy buttons#233
Conversation
Fixes axe-core button-name violation: the copy-to-clipboard button emitted by code-copy.js had no inner text, aria-label, or title. Add aria-label="Copy code", and aria-hidden="true" on the icon wrappers so the SVG isn't separately announced. Closes #222
cwickham
requested review from
gregswinehart,
ivelasq and
jeroenjanssens
as code owners
✅ Deploy Preview for posit-open-source canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-label="Copy code"to the copy-to-clipboard button emitted byassets/js/code-copy.jsso screen readers announce its purpose.aria-hidden="true"to the<i>wrappers around the copy/check SVG icons inlayouts/partials/extended_footer.htmlso the icon doesn't get announced separately.Closes #222
Test plan
hugo serveron a post containing code blocks — JS bundle includes the new attribute and rendered HTML showsaria-hiddenon the icon wrappers.button-nameviolation is gone.