Preserve R echo while narrowing echo cleanup#59
Merged
Conversation
Keep R-owned submitted-input echo on the visible IPC path while making prompt/readline echo matching source-aware. This prevents raw child stdout that looks like an R prompt from satisfying IPC-owned echo facts, without changing large echo collapse behavior. Validation: - cargo check - cargo build - cargo clippy --all-targets --all-features -- -D warnings - cargo test - cargo +nightly fmt
The macOS ARM PR CI run failed in timeout_spill_recreates_deleted_transcript_without_replaying_old_text: expected later small poll output to recreate the deleted spill file, got: "> " The test used elapsed sleeps to make tail output arrive after transcript.txt was deleted. Gate the R-side tail emission on a test-created file instead, wait until the pre-delete spill has reached mid080, then release the gate after deleting the transcript. Validation: - cargo check - cargo build - cargo clippy --all-targets --all-features -- -D warnings - cargo test - cargo +nightly fmt - codex review --base main
The macOS ARM PR CI run failed in python_idle_exit_preserves_detached_tail_before_respawn:
expected detached idle output to survive auto-respawn, got: "print('AFTER_RESPAWN')\r\nAFTER_RESPAWN\r\n>>> "
The test let the root Python worker exit immediately after the detached child reported that it had written IDLE_TAIL. Keep the root worker alive briefly after that marker so the server-side PTY reader can capture the detached tail before the auto-respawn path runs.
Validation:
- cargo check
- cargo build
- cargo clippy --all-targets --all-features -- -D warnings
- cargo test
- cargo +nightly fmt
- codex review --base main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an internal slice of the R output-ordering epic. It keeps the existing R echo UX intact while narrowing echo cleanup so IPC-owned prompt/readline facts only consume IPC-owned output, not raw child stdout.
Public changes
None intended.
Internal changes
rawvsipc) through output capture, pending output, pager replay, and echo collapse.Testing
cargo checkcargo buildcargo clippy --all-targets --all-features -- -D warningscargo testcargo +nightly fmtcodex review --base main