Skip to content

Add handler to allow for autosave #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+21 −1
Open

Add handler to allow for autosave #944

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7b5656
Add check for saving workspace
kv9898 Oct 13, 2025
1214679
Remove unnecessary unsafe scope
kv9898 Oct 13, 2025
161b00c
save vs no save: last one wins
kv9898 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion crates/ark/src/sys/windows/interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use crate::interface::r_suicide;
use crate::interface::r_write_console;
use crate::sys::windows::strings::system_to_utf8;

pub fn setup_r(mut _args: Vec<*mut c_char>) {
pub fn setup_r(mut args: Vec<*mut c_char>) {
unsafe {
libr::set(R_SignalHandlers, 0);

Expand Down Expand Up @@ -67,6 +67,26 @@ pub fn setup_r(mut _args: Vec<*mut c_char>) {
// R_DefParamsEx(params, bindings::RSTART_VERSION as i32);
R_DefParamsEx(params, 0);

let args_str: Vec<String> = args
.iter()
.map(|&arg| {
let cstr = CStr::from_ptr(arg);
cstr.to_string_lossy().to_string()
})
.collect();

// Determine save action by scanning args in order and letting the last
// occurrence of --save or --no-save win (mirrors R's last-one-wins behavior).
let mut save_action = libr::SA_TYPE_SA_NOSAVE;
for arg in &args_str {
match arg.as_str() {
"--save" => save_action = libr::SA_TYPE_SA_SAVE,
"--no-save" => save_action = libr::SA_TYPE_SA_NOSAVE,
_ => {},
}
}
(*params).SaveAction = save_action;

(*params).R_Interactive = 1;
(*params).CharacterMode = libr::UImode_RGui;

Expand Down