Recurse into special constructs to find document symbols #892
+824
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#8881
We now consistently recurse inside these constructs to collect nested document symbols such as comment sections:
The behaviour regarding nested assignments implemented in #859 has been adapted so that
{
blocks in if-else branches and loops still counts as top-level. This way these assignments are all treated as consistently part of the outline:In addition we also now collect comment sections in parameter lists of function definitions:
QA Notes
Comment sections and other kinds of document symbols in if-else branches and loops are now part of the outline:
Comment sections in parameter lists of function definitions are now included as well. We don't recurse through default arguments though.