Never flag _ as an unknown identifier
#804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tree-sitter parses this as an `identifier` node to keep things simple in the grammar, rather than parsing it as something like a `pipe_placeholder` within a pipe scope, which would be tough to do right. So we have to adapt to that here and always avoid flagging `_` as an unknown symbol.
lionel-
approved these changes
May 21, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#3749
Addresses posit-dev/positron#4102
tree-sitter parses this as an
identifiernode to keep things simple in the grammar, rather than parsing it as something like apipe_placeholderwithin a pipe scope, which would be tough to do right. So we have to adapt to that here and always avoid flagging_as an unknown symbol.