Include [ and [[ in call argument diagnostic disabling

[DavisVaughan]

Addresses posit-dev/positron#5271
Addresses part of posit-dev/positron#3749 (not the pipe part)

# We currently disable diagnostics anytime we are here:
fn(arg1, arg2)
  |----------|

# But not here
data[arg1, arg2]
    |----------|

# And not here
data[[arg1, arg2]]
    |------------|

This causes issues for data.table, who uses NSE inside [. We often treat function calls, subset, and subset2 pretty similarly (in the formatter they are treated almost identically). For now it seems like the right thing to do to make data.table usable in Positron is to also disable diagnostics inside subset (and subset2 for consistency).

I've done this by unifying some code paths that differed between the two and generalizing some field names.

[Copilot]

Pull Request Overview

This pull request unifies the handling of function calls and subset/subset2 nodes in the diagnostic logic to disable diagnostics for call-like arguments, addressing issues with data.table usage. Key changes include renaming the context flag from in_call to in_call_like_arguments, consolidating recursion functions for call-like nodes, and updating corresponding tests.

Comments suppressed due to low confidence (1)

crates/ark/src/lsp/diagnostics.rs:1340

• [nitpick] Ensure that the new test name accurately reflects that it now covers both function call diagnostics and subset/subset2 cases, making the purpose of the test clearer.

fn test_assignment_within_call_like() {