Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2024_Ravasini_Picene #238

Merged
merged 5 commits into from
Mar 18, 2025
Merged

Adding 2024_Ravasini_Picene #238

merged 5 commits into from
Mar 18, 2025

Conversation

stschiff
Copy link
Member

@stschiff stschiff commented Jan 16, 2025

PR Checklist for a new package submission

  • The package does not exist already in the community archive, also not with a different name.
  • The package title in the POSEIDON.yml conforms to the general title structure suggested here: <Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g. 2021_Zegarac_SoutheasternEurope, 2021_SeguinOrlando_BellBeaker or 2021_Kivisild_MedievalEstonia.
  • The package is stored in a directory that is named like the package title.

  • The package is complete and features the following elements:
    • Genotype data in binary PLINK format (not EIGENSTRAT format).
    • A POSEIDON.yml file with not just the file-referencing fields, but also the following meta-information fields present and filled: poseidonVersion, title, description, contributor, packageVersion, lastModified (see here for their definition)
    • A reasonably filled .janno file (for a list of available fields look here and here for more detailed documentation about them).
    • A .bib file with the necessary literature references for each sample in the .janno file.
  • Every file in the submission is correctly referenced in the POSEIDON.yml file and there are no additional, supplementary files in the submission that are not documented there.
  • Genotype data, .janno and .bib file are all named after the package title and only differ in the file extension.
  • The package version in the POSEIDON.yml file is 1.0.0.
  • The poseidonVersion of the package in the POSEIDON.yml file is set to the latest version of the Poseidon schema.
  • The POSEIDON.yml file contains the corresponding checksums for the fields genoFile, snpFile, indFile, jannoFile and bibFile.
  • There is either no CHANGELOG file or one with a single entry for version 1.0.0.

  • The Publication column in the .janno file is filled and the respective .bib file has complete entries for the listed mentioned keys.
  • The .janno file does not include any empty columns or columns only filled with n/a.
  • The order of columns in the .janno file adheres to the standard order as defined in the Poseidon schema here.
  • The .janno and the .ssf files are not fully quoted, so they only use single- or double quotes ("...", '...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).

  • The package passes a validation with trident validate --fullGeno.

  • Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

@stschiff stschiff self-assigned this Jan 31, 2025
@stschiff stschiff marked this pull request as ready for review February 12, 2025 16:28
@nevrome nevrome changed the title Adding Ravasini et al 2024 Picene Adding 2024_Ravasini_Picene Feb 13, 2025
@stschiff stschiff marked this pull request as draft February 18, 2025 10:28
@stschiff
Copy link
Member Author

OK, this is now ready for review!

@stschiff stschiff marked this pull request as ready for review February 24, 2025 11:21
@nevrome nevrome requested a review from TCLamnidis February 25, 2025 09:22
@nevrome
Copy link
Member

nevrome commented Feb 25, 2025

@TCLamnidis This is a rather minimal package with the bare necessities for analysis. Maybe you could have quick look if it's structurally fine. Thank you 🙏

@nevrome
Copy link
Member

nevrome commented Mar 13, 2025

@stschiff Angela and I identified an issue with the dating of the samples EV19 and EV7A. They are duplicated samples or monozygotic twins. And they are from the same burial chamber that is contextually (and with two other radiocarbon dates) dated to VII-VI cc. BCE. Curiously EV7A has a radiocarbon date that points to a younger age: 2310±30 BP (413-229 calBCE). The authors seem to have ignored this dating, but they do not explain or justify this decision in the paper or the supplement.

Angela and I think that we should ideally contact the authors about this. Alternatively we could follow their lead and use the age range they adopted for the paper. Then the radiocarbon age for EV7A should be removed from this Poseidon package.

@stschiff
Copy link
Member Author

Thanks! OK, I removed the C14 date from EV7A and adapted its contextual range to that of EV19. I think that's sufficient for now.

@nevrome
Copy link
Member

nevrome commented Mar 18, 2025

OK - I'll merge this.

@nevrome nevrome merged commit 0be4005 into master Mar 18, 2025
1 check passed
@nevrome nevrome deleted the add_2024_Ravasini_Picene branch March 18, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants