-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add package 2024_Barquera_ChichenItza #211
Add package 2024_Barquera_ChichenItza #211
Conversation
Hi @RodrigoBarquera, this is great. Super that you even entered the relationship columns, which I know is a lot of work. Sorry for taking so long to give feedback, but I have some points:
Again, let us know if you need help with this and we can ask someone from our team. |
@RodrigoBarquera did you have a chance to look into this, or do you need help from one of us? |
@RodrigoBarquera Another reminder. Please let us know if you would like to hand this over to an other assignee. |
Hi Stephan! :) With the help of Thiseas, I finally managed to complete the missing spots. Two things were left unchanged: the dating for all samples, as we found in the same context individuals spanning 500 years, we cannot accurately date any further by context. And the contamination estimates we don't have them consistently for all libraries for all individuals. If it is absolutely necessary, I can compile them and make a weighted average for the contamination estimates, but since eager 1 and 2 were used at the time, I would need to rerun everything on eager 2 to be consistent. But this would be from the TF data, since the SG is in all cases too low for it to get an accurate estimate. |
Thanks, @RodrigoBarquera. OK, maybe then forget about contamination, that's OK. But for the dates, please write here what the span is. Even something like 1000 - 2000 AD would be better than nothing, given that our repository has data from the last 40,000 years or so. I am happy to input them for you. |
Nevermind, just looked at your paper and saw 500-900 AD. That's perfect. I will enter this. |
OK, so if nobody objects, I would like to take over this PR now, by merging into a local branch and making the final touches. |
This PR is being further worked on in #250 |
PR Checklist for a new package submission
POSEIDON.yml
conforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>
, e.g.2021_Zegarac_SoutheasternEurope
,2021_SeguinOrlando_BellBeaker
or2021_Kivisild_MedievalEstonia
.POSEIDON.yml
file with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion
,title
,description
,contributor
,packageVersion
,lastModified
(see here for their definition).janno
file (for a list of available fields look here and here for more detailed documentation about them)..bib
file with the necessary literature references for each sample in the.janno
file.POSEIDON.yml
file and there are no additional, supplementary files in the submission that are not documented there..janno
and.bib
file are all named after the package title and only differ in the file extension.POSEIDON.yml
file is1.0.0
.poseidonVersion
of the package in thePOSEIDON.yml
file is set to the latest version of the Poseidon schema.POSEIDON.yml
file contains the corresponding checksums for the fieldsgenoFile
,snpFile
,indFile
,jannoFile
andbibFile
.CHANGELOG
file or one with a single entry for version1.0.0
.Publication
column in the.janno
file is filled and the respective.bib
file has complete entries for the listed mentioned keys..janno
file does not include any empty columns or columns only filled withn/a
..janno
file adheres to the standard order as defined in the Poseidon schema here..janno
and the.ssf
files are not fully quoted, so they only use single- or double quotes ("..."
,'...'
) to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno
.git lfs migrate import --no-rewrite path/to/file.bed
(see here).